Skip to content

Commit bcf933c

Browse files
committed
Fix billboard requestRender issue
1 parent c10c4e6 commit bcf933c

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

packages/engine/Source/DataSources/BillboardVisualizer.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ function BillboardVisualizer(entityCluster, entityCollection) {
7777
* Entity counterpart at the given time.
7878
*
7979
* @param {JulianDate} time The time to update to.
80-
* @returns {boolean} This function always returns true.
80+
* @returns {boolean} True if the visualizer successfully updated to the provided time,
81+
* false if the visualizer is waiting for asynchronous image textures to be created.
8182
*/
8283
BillboardVisualizer.prototype.update = function (time) {
8384
//>>includeStart('debug', pragmas.debug);
@@ -89,6 +90,7 @@ BillboardVisualizer.prototype.update = function (time) {
8990
const items = this._items.values;
9091
const cluster = this._cluster;
9192

93+
let ready = true;
9294
for (let i = 0, len = items.length; i < len; i++) {
9395
const item = items[i];
9496
const entity = item.entity;
@@ -226,6 +228,7 @@ BillboardVisualizer.prototype.update = function (time) {
226228
time,
227229
defaultSplitDirection,
228230
);
231+
ready = billboard._imageTexture.ready;
229232

230233
const subRegion = Property.getValueOrUndefined(
231234
billboardGraphics._imageSubRegion,
@@ -236,7 +239,7 @@ BillboardVisualizer.prototype.update = function (time) {
236239
billboard.setImageSubRegion(billboard.image, subRegion);
237240
}
238241
}
239-
return true;
242+
return ready;
240243
};
241244

242245
/**

0 commit comments

Comments
 (0)