Skip to content

Commit 29f8063

Browse files
committed
Naming fixes
1 parent 1133902 commit 29f8063

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

CHANGES.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
- Materials loaded from type now respect submaterials present in the referenced material type. [#10566](https://github.com/CesiumGS/cesium/issues/10566)
1010
- Reverts `createImageBitmap` options update to continue support for older browsers [#12846](https://github.com/CesiumGS/cesium/issues/12846)
1111
- Fix flickering artifact in Gaussian splat models caused by incorrect sorting results. [#12662](https://github.com/CesiumGS/cesium/issues/12662)
12+
- Fix render issues when updating entities with `requestRenderMode=true`. [#12543](https://github.com/CesiumGS/cesium/issues/12543)
1213

1314
#### Additions :tada:
1415

@@ -117,8 +118,6 @@ vec3 voxelNormal = fsInput.attributes.normalEC;
117118

118119
#### Additions :tada:
119120

120-
- Support Texture3D and add Volume Cloud SandBox Sample. [#12550](https://github.com/CesiumGS/cesium/issues/12550)
121-
- Fix render issues when updating entities with `requestRenderMode=true`. [#12543](https://github.com/CesiumGS/cesium/issues/12543)
122121
- Add basic support for draping imagery on 3D Tiles. [#12567](https://github.com/CesiumGS/cesium/pull/12567)
123122
- Add support for 3D Textures and add Volume Cloud sandcastle example. [#12661](https://github.com/CesiumGS/cesium/pull/12611)
124123

packages/engine/Source/DataSources/BillboardVisualizer.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ function BillboardVisualizer(entityCluster, entityCollection) {
7878
*
7979
* @param {JulianDate} time The time to update to.
8080
* @returns {boolean} True if the visualizer successfully updated to the provided time,
81-
* false if the visualizer is waiting for asynchronous image textures to be created.
81+
* false if the visualizer is waiting for asynchronous work to be completed.
8282
*/
8383
BillboardVisualizer.prototype.update = function (time) {
8484
//>>includeStart('debug', pragmas.debug);
@@ -90,7 +90,7 @@ BillboardVisualizer.prototype.update = function (time) {
9090
const items = this._items.values;
9191
const cluster = this._cluster;
9292

93-
let ready = true;
93+
let isUpdated = true;
9494
for (let i = 0, len = items.length; i < len; i++) {
9595
const item = items[i];
9696
const entity = item.entity;
@@ -228,7 +228,7 @@ BillboardVisualizer.prototype.update = function (time) {
228228
time,
229229
defaultSplitDirection,
230230
);
231-
ready = billboard.ready && ready;
231+
isUpdated = billboard.ready && isUpdated;
232232

233233
const subRegion = Property.getValueOrUndefined(
234234
billboardGraphics._imageSubRegion,
@@ -239,7 +239,7 @@ BillboardVisualizer.prototype.update = function (time) {
239239
billboard.setImageSubRegion(billboard.image, subRegion);
240240
}
241241
}
242-
return ready;
242+
return isUpdated;
243243
};
244244

245245
/**

0 commit comments

Comments
 (0)