Skip to content

Document Tag Typing #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2024
Merged

Document Tag Typing #37

merged 1 commit into from
May 16, 2024

Conversation

H00N24
Copy link
Collaborator

@H00N24 H00N24 commented May 13, 2024

This PR changes the Python wrapper typing from str to TagKind. Example from https://github.com/Certora/cvldocTool/blob/master/tests/customer_code/GovernorPreventLateQuorum-expected.json

In [22]: a = next(x for x in elements if x.element_name() == "proposalNotCreatedEffects")
In [23]: a.doc[0].kind
Out[23]: TagKind.Notice

@H00N24 H00N24 requested a review from pickx May 13, 2024 15:02
Copy link
Collaborator

@pickx pickx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@H00N24 H00N24 merged commit 0f23c2f into master May 16, 2024
4 checks passed
@H00N24 H00N24 deleted the fix/document-tag branch May 16, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants