-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Polkadot v1.6 to v1.7 upgrade #441
base: feat/polkadot-v1.6.0-upgrade
Are you sure you want to change the base?
Feat: Polkadot v1.6 to v1.7 upgrade #441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aideepakchaudhary please apply this change https://github.com/paritytech/polkadot-sdk/blob/2fe3145ab9bd26ceb5a26baf2a64105b0035a5a6/substrate/bin/node-template/runtime/src/lib.rs#L260
construct_runtime!(
- pub struct Runtime {
+ pub enum Runtime {
Same changes in cere_dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- #[cfg(feature = "runtime-benchmarks")]
- #[macro_use]
- extern crate frame_benchmarking;
-
#[cfg(feature = "runtime-benchmarks")]
mod benches {
- define_benchmarks!(
+ frame_benchmarking::define_benchmarks!(
For more details, please see here https://github.com/paritytech/polkadot-sdk/blob/2fe3145ab9bd26ceb5a26baf2a64105b0035a5a6/substrate/bin/node-template/runtime/src/lib.rs#L313
same changes in cere_dev
Description
This PR is upgrading Runtime's and Node's dependencies from Polkadot-SDK release
v1.6.0
tov1.7.0
Notes
Relevant upgrade's notes and comments.
MaxHolds
type from pallet balance's config.transaction
totransactionWatch
paritytech/polkadot-sdk#3040: Rename transaction to transactionWatchforce_adjust_total_issuance
paritytech/polkadot-sdk#3001: Introduce Balances::force_adjust_total_issuanceNonFungibleAdapter
paritytech/polkadot-sdk#2924: Add NonFungibleAdapter#[pallet::composite_enum]
improved variant count handling + removedpallet_balances
'sMaxHolds
config paritytech/polkadot-sdk#2657: [frame] #[pallet::composite_enum] improved variant count handling + removed pallet_balances's MaxHolds configProcess
spec_ver
for bothtestnet
andmainnet
Runtime.Codebase Upgrade Acceptance Criteria
cargo check
passescargo test
passescargo build
on-- release
profile correctly buildstry-runtime
andruntime-benchmarks
features compileblock-production
config file generates blocks.Runtime & Node Upgrade Acceptance Criteria
Runtime upgrade works on Zombienet
Node upgrade works on Zombienet
Runtime upgrade works on Chopsticks
Try-runtime passes with no pending migrations
<!--- PR TEMPLATE CONTENT STARTS HERE -->
Types of Changes
Please select the branch type you are merging and fill in the relevant template.
<!--- Check the following box with an x if the following applies: -->
Fix or Feature
<!--- Check the following box with an x if the following applies: -->
Types of Changes
<!--- What types of changes does your code introduce? -->
Migrations and Hooks
<!--- Check the following box with an x if the following applies: -->
on_initialize
on_finalize
Checklist for Fix or Feature
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->
spec_version
has been incremented.network-relayer
's events have been updated according to the blockchain events if applicable.Checklist for Hotfix
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->
spec_version
has been incremented.dev
has been created.staging
has been created.network-relayer
's events have been updated according to the blockchain events if applicable.Checklist for Release
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->