[ENG-10071] Feature/optimize subscription population script #11560
+355
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
reviewed
Jan 20, 2026
scripts/remove_after_use/populate_notification_subscriptions_user_global_file_updated.py
Show resolved
Hide resolved
scripts/populate_notification_subscriptions_user_global_file_updated.py
Outdated
Show resolved
Hide resolved
cslzchen
reviewed
Jan 21, 2026
scripts/populate_notification_subscriptions_user_global_file_updated.py
Outdated
Show resolved
Hide resolved
scripts/remove_after_use/populate_notification_subscriptions_user_global_file_updated.py
Show resolved
Hide resolved
cslzchen
reviewed
Jan 30, 2026
scripts/remove_after_use/populate_notification_subscriptions_node_file_updated.py
Show resolved
Hide resolved
scripts/remove_after_use/populate_notification_subscriptions_node_file_updated.py
Show resolved
Hide resolved
…lobal file updated
bodintsov
force-pushed
the
feature/optimize-subscription-population-script
branch
from
42c1937 to
799bedb
Compare
cslzchen
requested changes
Feb 2, 2026
| from osf.models import Node, NotificationSubscription, NotificationType | ||
|
|
||
|
|
||
| @celery_app.task(name='scripts.remove_after_use.populate_nodes_notification_subscriptions') |
Collaborator
There was a problem hiding this comment.
Rename TASK NAME from scripts.remove_after_use.populate_nodes_notification_subscriptions to scripts.remove_after_use.populate_notification_subscriptions_node_file_updated
|
|
||
|
|
||
| @celery_app.task(name='scripts.remove_after_use.populate_nodes_notification_subscriptions') | ||
| def populate_notification_subscriptions_user_global_file_updated(batch_size: int = 1000): |
Collaborator
There was a problem hiding this comment.
Incorrect name, use populate_notification_subscriptions_node_file_updated.
| print(f'Created {total_created} subscriptions.') | ||
| print('----Creation finished----') | ||
|
|
||
| @celery_app.task(name='scripts.remove_after_use.update_nodes_notification_subscriptions') |
Collaborator
There was a problem hiding this comment.
Similarly, rename the TASK NAME to scripts.remove_after_use.update_notification_subscriptions_node_file_updated
| print('----Creation finished----') | ||
|
|
||
| @celery_app.task(name='scripts.remove_after_use.update_nodes_notification_subscriptions') | ||
| def update_notification_subscriptions_user_global_file_updated(): |
Collaborator
There was a problem hiding this comment.
Incorrect name, should be update_notification_subscriptions_node_file_updated
website/settings/defaults.py
Outdated
Comment on lines
439
to
440
| 'scripts.remove_after_use.populate_nodes_notification_subscriptions', | ||
| 'scripts.remove_after_use.update_nodes_notification_subscriptions', |
Collaborator
There was a problem hiding this comment.
Needs to be updated as a result of aforementioned suggestions
website/settings/defaults.py
Outdated
Comment on lines
574
to
575
| 'scripts.remove_after_use.populate_nodes_notification_subscriptions', | ||
| 'scripts.remove_after_use.update_nodes_notification_subscriptions', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Optimize subscription population scripts
Changes
Optimize subscription population scripts
Side Effects
TBD
QE Notes
TBD
CE Notes
TBD
Documentation
TBD