[ENG-9050] Only admins and moderators and access moderation-related endpoints #11343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlius
approved these changes
Oct 2, 2025
adlius
merged commit 38ad074
into
CenterForOpenScience:feature/pbs-25-19
7 checks passed
adlius
added a commit
that referenced
this pull request
Oct 3, 2025
* [ENG-9020] Custom html host for legacy OSF (#11338) * custom html host for legacy OSF * fixed html links, added a test * anyone can duplicate public project (structure only) * remove capture_notifications as the result of rebasing from pbs-25-19 * allow READ users to create guid for files * validate only on permission change (#11336) * Fix fail from first attempt (#11342) * only moderator and admin can access moderation tabs (#11343) --------- Co-authored-by: ihorsokhanexoft <isokhan@exoft.net> Co-authored-by: Brian J. Geiger <bgeiger@pobox.com> Co-authored-by: Brian J. Geiger <bgeiger@cos.io> Co-authored-by: Anton Krytskyi <ant.krytskyi@gmail.com> Co-authored-by: bodintsov <bodintsov@exoft.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Any user can access moderation pages regardless of his permission, however only moderators and admins should be able to do it
Changes
Adjusted
MustBeModeratorpermission that controls access to moderation pages (collections, preprints, registrations)Adjusted
ContributorOrModeratorpermission that controls viewing registration actions (only moderators and admins can do that)QA Notes
Would be nice if QA team tests all endpoints manually and separately. The reason is that I manually opened appropriate pages to check what requests are made on these pages. All of them had
MustBeModeratorpermission.Notes
CollectionProviderActionListview is not used anywhere, so can be removed in the futureCollectionProviderSubmissionList,PreprintProviderPreprintList,RegistrationProviderSubmissionList- have custom permissions where usual user has access to specific data (like you are either admin or object is public/published). I assume this kind of data is displayed somewhere else for ordinary users, so they weren't covered with testsTicket
https://openscience.atlassian.net/browse/ENG-9050?atlOrigin=eyJpIjoiYmVhNDBlOTA2OTBmNDE4MWFhNTgzN2I5ZTc3ZmExYWIiLCJwIjoiaiJ9