Skip to content

Commit 62851fd

Browse files
author
Ramya Virajamangala
committed
Updated title as constant
1 parent 36e2d21 commit 62851fd

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

tests/test_metadata.py

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -482,10 +482,13 @@ def test_edit_support_funding_information(
482482
@markers.core_functionality
483483
class TestRegistrationMetadata:
484484
@pytest.fixture()
485-
def registration_metadata_page(self, driver):
486-
registration_guid = osf_api.get_registration_by_title(
487-
'Selenium Registration for Metadata tests'
488-
)
485+
def title(self):
486+
TITLE = 'Selenium Registration for Metadata tests'
487+
return TITLE
488+
489+
@pytest.fixture()
490+
def registration_metadata_page(self, driver, title):
491+
registration_guid = osf_api.get_registration_by_title(title)
489492
osf_api.update_registration_metadata_with_custom_data(registration_guid)
490493
registration_metadata_page = RegistrationMetadataPage(
491494
driver, guid=registration_guid
@@ -494,21 +497,19 @@ def registration_metadata_page(self, driver):
494497
return registration_metadata_page
495498

496499
@pytest.fixture()
497-
def registration_guid(self):
498-
registration_guid = osf_api.get_registration_by_title(
499-
'Selenium Registration for Metadata tests'
500-
)
500+
def registration_guid(self, title):
501+
registration_guid = osf_api.get_registration_by_title(title)
501502
return registration_guid
502503

503504
def test_edit_metadata_title_and_description(
504-
self, driver, registration_metadata_page, fake, registration_guid
505+
self, driver, registration_metadata_page, fake, registration_guid, title
505506
):
506507
"""This test verifies that the registration metadata title
507508
and description fields are editable and changes are saved."""
508509

509510
new_title = fake.sentence(nb_words=2)
510511
new_description = fake.sentence(nb_words=4)
511-
original_title = 'Selenium Registration for Metadata tests'
512+
# original_title = 'Selenium Registration for Metadata tests'
512513

513514
WebDriverWait(driver, 5).until(
514515
EC.element_to_be_clickable(
@@ -540,8 +541,11 @@ def test_edit_metadata_title_and_description(
540541
assert new_description == utils.clean_text(
541542
registration_metadata_page.metadata_description.text
542543
)
544+
assert new_title == utils.clean_text(
545+
registration_metadata_page.metadata_title.text
546+
)
543547
osf_api.update_registration_title(
544-
registration_guid=registration_guid, title=original_title
548+
registration_guid=registration_guid, title=title
545549
)
546550

547551
def test_edit_contributors(

0 commit comments

Comments
 (0)