Refactor assertions to reusable function for affiliated institutions

Author: Shtogryn

pages/preprints.py

@@ -212,6 +212,13 @@ def select_top_level_subject(self, selection):
     def get_preprint_institution_list_review(self) -> list:
         return [el.get_attribute('alt') for el in self.preprint_institution_list_review]
 
+    def assert_affiliated_institutions_equal(self, expected, actual, page_name):
+        assert expected == actual, (
+            f'Affiliated institutions on the {page_name} do not match expected values.\n'
+            f'Expected: {expected}\n'
+            f'Actual: {actual}'
+        )
+
     # Preprint Detail Page
     preprint_institution_list_detail = GroupLocator(
         By.CSS_SELECTOR, 'img[data-test-preprint-institution-list]'

tests/test_preprints.py

@@ -211,13 +211,10 @@ def test_create_preprint_from_landing(
             affiliated_institutions_names_review_page = (
                 submit_page.get_preprint_institution_list_review()
             )
-            assert (
-                affiliated_institutions_names_metadata_page
-                == affiliated_institutions_names_review_page
-            ), (
-                f'Affiliated institutions on the Review Page do not match expected values.\n'
-                f'Expected: {affiliated_institutions_names_metadata_page }\n'
-                f'Actual: {affiliated_institutions_names_review_page}'
+            submit_page.assert_affiliated_institutions_equal(
+                affiliated_institutions_names_metadata_page,
+                affiliated_institutions_names_review_page,
+                'Preprint Review Page',
             )
             submit_page.info_toast.here_then_gone()
             submit_page.create_preprint_button.click()
@@ -227,13 +224,10 @@ def test_create_preprint_from_landing(
             affiliated_institutions_names_detail_page = (
                 submit_page.get_preprint_institution_list_detail()
             )
-            assert (
-                affiliated_institutions_names_metadata_page
-                == affiliated_institutions_names_detail_page
-            ), (
-                f'Affiliated institutions on the Preprint Detail Page do not match expected values.\n'
-                f'Expected: {affiliated_institutions_names_metadata_page }\n'
-                f'Actual: {affiliated_institutions_names_detail_page}'
+            submit_page.assert_affiliated_institutions_equal(
+                affiliated_institutions_names_metadata_page,
+                affiliated_institutions_names_detail_page,
+                'Preprint Detail Page',
             )
             # Capture guid of supplemental materials project created during workflow
             supplemental_url = preprint_detail.view_page.get_attribute('href')