Style changes

Author: AddisonSchiller

mfr/core/utils.py

@@ -1,7 +1,9 @@
 from stevedore import driver
 
 from mfr.core import exceptions
+import logging
 
+logger = logging.getLogger(__name__)
 
 def make_provider(name, request, url):
     """Returns an instance of :class:`mfr.core.provider.BaseProvider`
@@ -76,6 +78,7 @@ def make_renderer(name, metadata, file_path, url, assets_url, export_url):
     :rtype: :class:`mfr.core.extension.BaseRenderer`
     """
     normalized_name = (name and name.lower()) or 'none'
+    logger.info(str(metadata.is_public))
     if metadata.is_public:
         try:
             return driver.DriverManager(
@@ -86,6 +89,7 @@ def make_renderer(name, metadata, file_path, url, assets_url, export_url):
             ).driver
         except:
             # Check for a public renderer, if one doesn't exist, use a regular one
+            # Real exceptions handled by main driver.DriverManager
             pass
 
     try:

mfr/providers/osf/provider.py

@@ -117,6 +117,8 @@ async def metadata(self):
         self.metrics.add('metadata.clean_url_args', str(cleaned_url))
         unique_key = hashlib.sha256((metadata['data']['etag'] + cleaned_url.url).encode('utf-8')).hexdigest()
 
+        is_public = False
+
         if 'public_file' in cleaned_url.args:
             if cleaned_url.args['public_file'] not in ['0', '1']:
                 raise exceptions.QueryParameterError(
@@ -127,12 +129,7 @@ async def metadata(self):
                     code=400,
                 )
 
-            if cleaned_url.args['public_file'] == '1':
-                is_public = True
-            else:
-                is_public = False
-        else:
-            is_public = False
+            is_public = cleaned_url.args['public_file'] == '1'
 
         return provider.ProviderMetadata(name, ext, content_type,
                     unique_key, download_url, is_public=is_public)

setup.py

@@ -42,7 +42,6 @@ def parse_requirements(requirements):
         ],
         'mfr.public_renderers': [
             '.docx = mfr.extensions.office365:Office365Renderer',
-
         ],
         'mfr.exporters': [
             # google docs