Skip to content

Ship kernels.sqlite that was previously excluded #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

jimgao1
Copy link
Contributor

@jimgao1 jimgao1 commented Nov 5, 2022

No description provided.

@jimgao1 jimgao1 requested a review from anurlybayev November 5, 2022 01:50
@anurlybayev
Copy link
Contributor

@jimgao1 can you elaborate on what this will allow us to do? Maybe provide a historical context on why we excluded it and why we needed it now?

@jimgao1
Copy link
Contributor Author

jimgao1 commented Nov 7, 2022

@jimgao1 can you elaborate on what this will allow us to do? Maybe provide a historical context on why we excluded it and why we needed it now?

This file contains the number of registers used for each kernel launched. This information is used during wave scaling.

We have simply overlooked this file in the past, since all the testing was done by using the extract_models.sh mechanism instead of git LFS.

Copy link
Contributor

@anurlybayev anurlybayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@jimgao1 jimgao1 merged commit 1b96ed7 into main Nov 7, 2022
@michaelshin michaelshin deleted the nov04-fix-kernels-sqlite branch May 1, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants