Skip to content
This repository was archived by the owner on Mar 28, 2025. It is now read-only.

Conversation

@HCrane
Copy link
Contributor

@HCrane HCrane commented Dec 21, 2020

  • adds hash header to the featured projects
  • fixes a bug with DELETE - /authentication

Your checklist for this pull request

Please review the contributing guidelines of this repository.

  • Include the name and id of the Jira ticket in the PR’s title eg.: SHARE-666 The devils ticket
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no warnings and errors
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Verify that all tests are passing, if not please state the test cases in the section below
  • Perform a self-review of the changes
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • Put your ticket into the Code Review section in Jira
  • Post a message in the #catroweb Slack channel and ask for a code reviewer

Additional Description

TODO: Add additional information that is not in your commit-message here

Tests - additional information

TODO: add additional information about testruns here

- adds hash header to the featured projects
- fixes a bug with `DELETE - /authentication`
@HCrane HCrane requested a review from dmetzner December 21, 2020 15:20
@dmetzner dmetzner self-requested a review December 21, 2020 16:31
@HCrane HCrane merged commit 68935da into Catrobat:develop Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants