SHARE-234 github Actions, here we come :)

- run PhpUnit tests on every pull request
- create pull request on merge into develop to
  - remove old auto generated code
  - generate new code
  - fix code style

Author: dmetzner

.github/workflows/create_pull_request.yml

@@ -0,0 +1,55 @@
+name: Create Pull Request
+
+on:
+  push:
+    branches:
+      - develop
+
+jobs:
+
+  createPullRequest:
+
+    name: Create Pull Request
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Clean old files
+        run: |
+          rm -rf .openapi-generator Api Controller DependencyInjection Model Resources Service Tests
+
+      - name: Open API code generation
+        run:
+          docker run --rm -v "${PWD}:/local" openapitools/openapi-generator-cli:v5.0.0-beta generate -i local/catroweb.yaml -g php-symfony -p sortParamsByRequiredFlag=true -p skipFormModel=true -p variableNamingConvention=snake_case -p phpLegacySupport=false -o /local
+
+      - name: Fix code style
+        uses: docker://oskarstark/php-cs-fixer-ga:latest
+        with:
+          args: --allow-risky=yes
+
+      - name: Create Pull Request
+        id: cpr
+        uses: peter-evans/create-pull-request@v2
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          commit-message: Automated php-cs-fixer
+          committer: Catrobot <Catrobot@catroweb.github.com>
+          title: 'Bump autogenerated open API code'
+          body: |
+            Automatic Open API Code Generation
+
+            This pull request is autogenerated using the latest catroweb.yml swagger specificatons
+            from the develop branch and is updated automatically with every new change merged into the develop branch.
+
+            - removes old autogenerated files
+            - run open API generator (Symfony-Php)
+            - fix code style (Php-cs-fixer)
+
+            For more information checkout the action '.github/workflows/create_pull_request.yml'
+          labels: automated, open-api-generator, php-cs-fixer
+
+      - name: Check outputs
+        run: |
+          echo "Pull Request Number - ${{ env.PULL_REQUEST_NUMBER }}"
+          echo "Pull Request Number - ${{ steps.cpr.outputs.pull-request-number }}"

.github/workflows/tests.yml

@@ -0,0 +1,38 @@
+name: Tests
+
+on:
+  push:
+    branches:
+      - master
+      - develop
+  pull_request:
+
+jobs:
+
+  tests:
+    name: PHPUnit
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Validate composer.json and composer.lock
+        run: composer validate
+
+      - name: Cache Composer packages
+        id: composer-cache
+        uses: actions/cache@v2
+        with:
+          path: vendor
+          key: ${{ runner.os }}-php-${{ hashFiles('**/composer.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-php-
+
+      - name: Install dependencies
+        if: steps.composer-cache.outputs.cache-hit != 'true'
+        run: composer install --prefer-dist --no-progress --no-suggest
+
+      # Add a test script to composer.json, for instance: "test": "vendor/bin/phpunit"
+      # Docs: https://getcomposer.org/doc/articles/scripts.md
+      - name: Run test suite
+        run: composer run-script test

.gitignore

@@ -1,7 +1,5 @@
 # ref: https://github.com/github/gitignore/blob/master/Symfony.gitignore
 
-.idea/
-
 # Cache and logs (Symfony2)
 /app/cache/*
 /app/logs/*

.openapi-generator/FILES

@@ -36,33 +36,8 @@
 ./Service/SymfonyValidator.php
 ./Service/TypeMismatchException.php
 ./Service/ValidatorInterface.php
-./Tests/Api/AuthenticationApiInterfaceTest.php
-./Tests/Api/MediaLibraryApiInterfaceTest.php
-./Tests/Api/ProjectsApiInterfaceTest.php
-./Tests/Api/UserApiInterfaceTest.php
-./Tests/Api/UtilityApiInterfaceTest.php
 ./Tests/AppKernel.php
 ./Tests/Controller/ControllerTest.php
-./Tests/Model/BaseUserTest.php
-./Tests/Model/DryRunTest.php
-./Tests/Model/FeaturedProjectTest.php
-./Tests/Model/JWTTokenResponseTest.php
-./Tests/Model/LoginTest.php
-./Tests/Model/MediaCategoriesTest.php
-./Tests/Model/MediaCategoryTest.php
-./Tests/Model/MediaFileTest.php
-./Tests/Model/MediaPackageTest.php
-./Tests/Model/MediaPackagesTest.php
-./Tests/Model/ProjectTest.php
-./Tests/Model/ProjectUploadTest.php
-./Tests/Model/RegisterErrorTest.php
-./Tests/Model/RegisterTest.php
-./Tests/Model/UpdateUserAllOfTest.php
-./Tests/Model/UpdateUserErrorTest.php
-./Tests/Model/UpdateUserTest.php
-./Tests/Model/UploadErrorTest.php
-./Tests/Model/UserPrivateGetTest.php
-./Tests/Model/UserPublicGetTest.php
 ./Tests/test_config.yml
 .coveralls.yml
 .gitignore

Controller/MediaLibraryController.php

@@ -396,7 +396,7 @@ public function mediaPackagePackageNameGetAction(Request $request, $package_name
         $asserts = [];
         $asserts[] = new Assert\NotNull();
         $asserts[] = new Assert\Type("string");
-        $asserts[] = new Assert\Regex("/^[a-zA-Z0-9-_]+$/");
+        $asserts[] = new Assert\Regex("/^[a-zA-Z0-9\\-_]+$/");
         $response = $this->validate($package_name, $asserts);
         if ($response instanceof Response) {
             return $response;

Controller/ProjectsController.php

@@ -87,7 +87,7 @@ public function projectProjectIdGetAction(Request $request, $project_id)
         $asserts = [];
         $asserts[] = new Assert\NotNull();
         $asserts[] = new Assert\Type("string");
-        $asserts[] = new Assert\Regex("/^[a-zA-Z0-9-]+$/");
+        $asserts[] = new Assert\Regex("/^[a-zA-Z0-9\\-]+$/");
         $response = $this->validate($project_id, $asserts);
         if ($response instanceof Response) {
             return $response;
@@ -189,7 +189,6 @@ public function projectsFeaturedGetAction(Request $request)
         }
         $asserts = [];
         $asserts[] = new Assert\Type("string");
-        $asserts[] = new Assert\Regex("/[0-9]\\.[0-9]{3}/");
         $response = $this->validate($max_version, $asserts);
         if ($response instanceof Response) {
             return $response;
@@ -318,7 +317,6 @@ public function projectsGetAction(Request $request)
         }
         $asserts = [];
         $asserts[] = new Assert\Type("string");
-        $asserts[] = new Assert\Regex("/[0-9]\\.[0-9]{3}/");
         $response = $this->validate($max_version, $asserts);
         if ($response instanceof Response) {
             return $response;
@@ -563,7 +561,6 @@ public function projectsSearchGetAction(Request $request)
         }
         $asserts = [];
         $asserts[] = new Assert\Type("string");
-        $asserts[] = new Assert\Regex("/[0-9]\\.[0-9]{3}/");
         $response = $this->validate($max_version, $asserts);
         if ($response instanceof Response) {
             return $response;
@@ -677,7 +674,6 @@ public function projectsUserGetAction(Request $request)
         // Validate the input values
         $asserts = [];
         $asserts[] = new Assert\Type("string");
-        $asserts[] = new Assert\Regex("/[0-9]\\.[0-9]{3}/");
         $response = $this->validate($max_version, $asserts);
         if ($response instanceof Response) {
             return $response;
@@ -795,14 +791,13 @@ public function projectsUserUserIdGetAction(Request $request, $user_id)
         $asserts = [];
         $asserts[] = new Assert\NotNull();
         $asserts[] = new Assert\Type("string");
-        $asserts[] = new Assert\Regex("/^[a-zA-Z0-9-]+$/");
+        $asserts[] = new Assert\Regex("/^[a-zA-Z0-9\\-]+$/");
         $response = $this->validate($user_id, $asserts);
         if ($response instanceof Response) {
             return $response;
         }
         $asserts = [];
         $asserts[] = new Assert\Type("string");
-        $asserts[] = new Assert\Regex("/[0-9]\\.[0-9]{3}/");
         $response = $this->validate($max_version, $asserts);
         if ($response instanceof Response) {
             return $response;

Controller/UserController.php

@@ -225,7 +225,7 @@ public function userIdGetAction(Request $request, $id)
         $asserts = [];
         $asserts[] = new Assert\NotNull();
         $asserts[] = new Assert\Type("string");
-        $asserts[] = new Assert\Regex("/^[a-zA-Z0-9-]+$/");
+        $asserts[] = new Assert\Regex("/^[a-zA-Z0-9\\-]+$/");
         $response = $this->validate($id, $asserts);
         if ($response instanceof Response) {
             return $response;

Resources/config/routing.yml

@@ -42,7 +42,7 @@ open_api_server_mediaLibrary_mediapackagepackagenameget:
     defaults:
         _controller: open_api_server.controller.mediaLibrary:mediaPackagePackageNameGetAction
     requirements:
-        package_name: '^[a-zA-Z0-9-_]+$'
+        package_name: '^[a-zA-Z0-9\\-_]+$'
 
 # projects
 open_api_server_projects_projectprojectidget:
@@ -51,7 +51,7 @@ open_api_server_projects_projectprojectidget:
     defaults:
         _controller: open_api_server.controller.projects:projectProjectIdGetAction
     requirements:
-        project_id: '^[a-zA-Z0-9-]+$'
+        project_id: '^[a-zA-Z0-9\\-]+$'
 
 open_api_server_projects_projectsfeaturedget:
     path:     /projects/featured
@@ -89,7 +89,7 @@ open_api_server_projects_projectsuseruseridget:
     defaults:
         _controller: open_api_server.controller.projects:projectsUserUserIdGetAction
     requirements:
-        user_id: '^[a-zA-Z0-9-]+$'
+        user_id: '^[a-zA-Z0-9\\-]+$'
 
 # user
 open_api_server_user_userdelete:
@@ -110,7 +110,7 @@ open_api_server_user_useridget:
     defaults:
         _controller: open_api_server.controller.user:userIdGetAction
     requirements:
-        id: '^[a-zA-Z0-9-]+$'
+        id: '^[a-zA-Z0-9\\-]+$'
 
 open_api_server_user_userpost:
     path:     /user