Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7Rewards: PDF417 barcode generation bug #30

Open
TheLastProject opened this issue Oct 24, 2020 · 3 comments
Open

7Rewards: PDF417 barcode generation bug #30

TheLastProject opened this issue Oct 24, 2020 · 3 comments
Labels
common: uncommon Most users are unlikely to come across this or unexpected workflow severity: major Severely degrades major functionality or product features, with no satisfactory workaround subject: store quirk Something non-standard related to a specific store type: bug Something isn't working

Comments

@TheLastProject
Copy link
Member

Issue by albuic
Wednesday Jul 11, 2018 at 00:41 GMT
Originally opened as brarcher/loyalty-card-locker#258


The generation of PDF417 seems to be buggy when using line break characters.
You can test the difference between the app and another generator like https://barcode.tec-it.com/en/PDF417?data=hello%0Ahere
It might be a bug in the zxing library but I did not find anything about it on here: https://github.com/zxing/zxing/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+pdf

Otherwise it might be the difference between linux and windows line break encoding: LF vs CR+LF
In that case a checkbox to select the type of line break (per barcode) might be needed.

For information, the 7Eleven stores in the US use this type of barcode for their loyalty cards (named 7Rewards program) and the generated barcode on the 7Eleven card is the same as the one in the URL above.

(Really nice App btw ;-) )

@TheLastProject
Copy link
Member Author

Comment by brarcher
Wednesday Jul 11, 2018 at 02:53 GMT


Hm. Looking at the barcode generator you referenced I do see that the barcode reported by the app is different. It believes the text is the same, though.

I created a card by capturing the 'hello%0Ahere' example, then exported the cards and looked at the strings with xxd. The following is the string as the app understand is:

6865 6c6c 6f0a 6865 7265 hello.here

which means it did correctly capture and encode the LF character.

Could you take a look at the xzing test app on the Play Store and see if the issue is there as well? That may help limit where the issue is.

It might be that there is some additional argument that needs to be passed to the xzing library when generating PDF417 barcodes, and I'm not aware of it.

@TheLastProject
Copy link
Member Author

Comment by albuic
Wednesday Jul 11, 2018 at 04:20 GMT


I tried their app but it cannot generate that barcode unfortunately !
One thing I did not mentioned is that all Apps decode any barcode correctly, the problem is only the barcode generation.

Edit: Just tried SecScanQR (https://github.com/Fr4gorSoftware/SecScanQR) and it also has the same problem when generating the barcode. And you both use the same library 😉

@TheLastProject TheLastProject changed the title PDF417 barcode generation bug 7Rewards: PDF417 barcode generation bug Nov 26, 2020
@TheLastProject TheLastProject added the subject: store quirk Something non-standard related to a specific store label Nov 26, 2020
@TheLastProject
Copy link
Member Author

I'm tagging this with "store quirk" as the behaviour of the app doesn't necessarily seem wrong but 7Eleven wants it a specific way apparently.

@TheLastProject TheLastProject added common: uncommon Most users are unlikely to come across this or unexpected workflow severity: major Severely degrades major functionality or product features, with no satisfactory workaround type: bug Something isn't working labels Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common: uncommon Most users are unlikely to come across this or unexpected workflow severity: major Severely degrades major functionality or product features, with no satisfactory workaround subject: store quirk Something non-standard related to a specific store type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant