fix clang-tidy warning modernize-use-equals-default

Author: fphammerle

.clang-tidy

@@ -20,7 +20,6 @@ WarningsAsErrors: >-
   -cppcoreguidelines-pro-type-vararg,
   -cppcoreguidelines-special-member-functions,
   -modernize-use-emplace,
-  -modernize-use-equals-default,
   -modernize-use-equals-delete,
   -modernize-use-noexcept,
   -performance-inefficient-vector-operation,

lib/HdfItem.cpp

@@ -32,8 +32,7 @@ std::string hdf4cpp::HdfItem::HdfDatasetItem::getName() const {
 int32 hdf4cpp::HdfItem::HdfDatasetItem::getId() const {
     return id;
 }
-hdf4cpp::HdfItem::HdfDatasetItem::~HdfDatasetItem() {
-}
+hdf4cpp::HdfItem::HdfDatasetItem::~HdfDatasetItem() = default;
 hdf4cpp::HdfItem::HdfGroupItem::HdfGroupItem(int32 id, const HdfDestroyerChain &chain)
     : HdfItemBase(id, VGROUP, chain) {
     char _name[MAX_NAME_LENGTH];
@@ -53,17 +52,15 @@ std::string hdf4cpp::HdfItem::HdfGroupItem::getName() const {
 int32 hdf4cpp::HdfItem::HdfGroupItem::getId() const {
     return id;
 }
-hdf4cpp::HdfItem::HdfGroupItem::~HdfGroupItem() {
-}
+hdf4cpp::HdfItem::HdfGroupItem::~HdfGroupItem() = default;
 hdf4cpp::HdfItem::HdfDataItem::HdfDataItem(int32 id, const HdfDestroyerChain &chain)
     : HdfItemBase(id, VDATA, chain) {
     this->chain.pushBack(new HdfDestroyer(&VSdetach, id));
     char _name[MAX_NAME_LENGTH];
     VSinquire(id, &nrRecords, &interlace, nullptr, &recordSize, _name);
     name = std::string(_name);
 }
-hdf4cpp::HdfItem::HdfDataItem::~HdfDataItem() {
-}
+hdf4cpp::HdfItem::HdfDataItem::~HdfDataItem() = default;
 hdf4cpp::HdfAttribute hdf4cpp::HdfItem::HdfDataItem::getAttribute(const std::string &name) const {
     return HdfAttribute(new HdfAttribute::HdfDataAttribute(id, name, chain));
 }

tests/HdfFileTest.cpp

@@ -9,11 +9,7 @@ using namespace hdf4cpp;
 
 class HdfFileTest : public ::testing::Test {
   protected:
-    HdfFileTest()
-        : file(std::string(TEST_DATA_PATH) + "small_test.hdf") {
-    }
-
-    HdfFile file;
+    HdfFile file{TEST_DATA_PATH "small_test.hdf"};
 };
 
 TEST_F(HdfFileTest, DatasetValidity) {
@@ -236,4 +232,4 @@ TEST_F(HdfFileTest, VdataDestroyer) {
     std::vector<int32> vec;
     attribute.get(vec);
     ASSERT_EQ(vec, std::vector<int32>({1, 2, 3, 3, 2, 1}));
-}
+}