Skip to content

Tabs #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Tabs #3

wants to merge 2 commits into from

Conversation

windowsmas
Copy link

I have made some progress on the tabs step todo. As you can see I have enhanced the tabs and added a Tab toolbar.

@windowsmas windowsmas mentioned this pull request May 26, 2023
3 tasks
@jdev082 jdev082 changed the title Enhancing tabs Tabs May 26, 2023
@jdev082
Copy link
Contributor

jdev082 commented May 26, 2023

Error:

Traceback (most recent call last):
  File "/var/home/j/Projects/Catalyst5/src/main.py", line 119, in <module>
    window = MainWindow()
             ^^^^^^^^^^^^
  File "/var/home/j/Projects/Catalyst5/src/main.py", line 41, in __init__
    self.addToolBar(tapwip)
                    ^^^^^^
NameError: name 'tapwip' is not defined. Did you mean: 'tabwip'?

@jdev082
Copy link
Contributor

jdev082 commented May 26, 2023

The error is because you misspelled a variable on line 41. @windowsmas

@jdev082 jdev082 marked this pull request as draft May 26, 2023 17:41
@jdev082
Copy link
Contributor

jdev082 commented May 26, 2023

@windowsmas So far a tab bar does show. Here is how I want tabs to work:

  • Add tab button
  • When this add tab button is pressed it should make a new tab and go to the home page
  • Each tab should retain it's URL even as the user switches between tabs

If this sounds confusing, think about how other browser's tabs work. Same thing.

@jdev082
Copy link
Contributor

jdev082 commented Jul 20, 2023

@windowsmas are you still working on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants