Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way the Hamiltonian is specified #170

Open
mortele opened this issue Mar 11, 2022 · 0 comments
Open

Change the way the Hamiltonian is specified #170

mortele opened this issue Mar 11, 2022 · 0 comments
Labels
cleanup ...on aisle seven enhancement New feature or request refactor Code rewrite

Comments

@mortele
Copy link
Member

mortele commented Mar 11, 2022

The way the Hamiltonian form is specified is not scalable. We should consider changing it to where something like this is a valid specification:

hamiltonian = [
    "chi-interaction", 
    "kappa-incompressibility",
]

or

hamiltonian = [
    "phi-squared", 
]

or

hamiltonian = [
    "chi-interaction", 
    "carnahan–starling",
]

or

hamiltonian = [
    "chi-interaction", 
    "carnahan–starling",
]

or

hamiltonian = [
    "chi-interaction", 
    "phi-squared",
    "kappa-incompressibility",
]

This would allow easy and intuitive combinations of Hamiltonian forms in the long term.

@mortele mortele added enhancement New feature or request refactor Code rewrite cleanup ...on aisle seven labels Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup ...on aisle seven enhancement New feature or request refactor Code rewrite
Projects
None yet
Development

No branches or pull requests

1 participant