Upgrade Carter.ResponseNegotiators to reference latest Carter

jchannon · jchannon · commit 82cc052b54c8 · 2023-07-26T19:38:07.000+01:00
diff --git a/src/Carter.ResponseNegotiators.Newtonsoft/Carter.ResponseNegotiators.Newtonsoft.csproj b/src/Carter.ResponseNegotiators.Newtonsoft/Carter.ResponseNegotiators.Newtonsoft.csproj
@@ -19,8 +19,8 @@
     </ItemGroup>
 
     <ItemGroup>
-        <PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
-        <PackageReference Include="Carter" Version="7.0.0"/>
+        <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
+        <PackageReference Include="Carter" Version="7.1.0" />
         <PackageReference Include="MinVer" Version="2.5.0">
             <PrivateAssets>all</PrivateAssets>
         </PackageReference>
diff --git a/src/Carter.ResponseNegotiators.Newtonsoft/NewtonsoftJsonResponseNegotiator.cs b/src/Carter.ResponseNegotiators.Newtonsoft/NewtonsoftJsonResponseNegotiator.cs
@@ -28,7 +28,7 @@ public bool CanHandle(MediaTypeHeaderValue accept)
     {
         return accept.MediaType.ToString().IndexOf("json", StringComparison.OrdinalIgnoreCase) >= 0;
     }
-    public Task Handle(HttpRequest req, HttpResponse res, object model, CancellationToken cancellationToken)
+    public Task Handle<T>(HttpRequest req, HttpResponse res, T model, CancellationToken cancellationToken)
     {
         res.ContentType = "application/json; charset=utf-8";
         return res.WriteAsync(JsonConvert.SerializeObject(model, this.jsonSettings), cancellationToken);
diff --git a/test/Carter.ResponseNegotiators.Newtonsoft.Tests/Carter.ResponseNegotiators.Newtonsoft.Tests.csproj b/test/Carter.ResponseNegotiators.Newtonsoft.Tests/Carter.ResponseNegotiators.Newtonsoft.Tests.csproj
@@ -1,16 +1,13 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
 
-
     <ItemGroup>
-        <PackageReference Include="MartinCostello.Logging.XUnit" Version="0.1.0" />
-        <PackageReference Include="Carter" Version="7.0.0" />
+        <PackageReference Include="MartinCostello.Logging.XUnit" Version="0.1.0"/>
     </ItemGroup>
 
 
-
     <ItemGroup>
-      <ProjectReference Include="..\..\src\Carter.ResponseNegotiators.Newtonsoft\Carter.ResponseNegotiators.Newtonsoft.csproj" />
+        <ProjectReference Include="..\..\src\Carter.ResponseNegotiators.Newtonsoft\Carter.ResponseNegotiators.Newtonsoft.csproj"/>
     </ItemGroup>
 
 
diff --git a/test/Carter.ResponseNegotiators.Newtonsoft.Tests/NewtonsoftJsonResponseNegotiatorTests.cs b/test/Carter.ResponseNegotiators.Newtonsoft.Tests/NewtonsoftJsonResponseNegotiatorTests.cs
@@ -87,7 +87,7 @@ public bool CanHandle(MediaTypeHeaderValue accept) => accept
             .IndexOf("application/vnd.badger+json",
                 StringComparison.OrdinalIgnoreCase) >= 0;
 
-        public async Task Handle(HttpRequest req, HttpResponse res, object model,
+        public async Task Handle<T>(HttpRequest req, HttpResponse res, T model,
             CancellationToken cancellationToken = default(CancellationToken))
         {
             await res.WriteAsync("Non default json Response", cancellationToken);

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public bool CanHandle(MediaTypeHeaderValue accept)`
`28`	`28`	`{`
`29`	`29`	`return accept.MediaType.ToString().IndexOf("json", StringComparison.OrdinalIgnoreCase) >= 0;`
`30`	`30`	`}`
`31`		`- public Task Handle(HttpRequest req, HttpResponse res, object model, CancellationToken cancellationToken)`
	`31`	`+ public Task Handle<T>(HttpRequest req, HttpResponse res, T model, CancellationToken cancellationToken)`
`32`	`32`	`{`
`33`	`33`	`res.ContentType = "application/json; charset=utf-8";`
`34`	`34`	`return res.WriteAsync(JsonConvert.SerializeObject(model, this.jsonSettings), cancellationToken);`
Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ public bool CanHandle(MediaTypeHeaderValue accept) => accept`
`87`	`87`	`.IndexOf("application/vnd.badger+json",`
`88`	`88`	`StringComparison.OrdinalIgnoreCase) >= 0;`
`89`	`89`
`90`		`- public async Task Handle(HttpRequest req, HttpResponse res, object model,`
	`90`	`+ public async Task Handle<T>(HttpRequest req, HttpResponse res, T model,`
`91`	`91`	`CancellationToken cancellationToken = default(CancellationToken))`
`92`	`92`	`{`
`93`	`93`	`await res.WriteAsync("Non default json Response", cancellationToken);`