Skip to content

Commit 175fbcb

Browse files
committed
Tiger feedback
1 parent 49e6708 commit 175fbcb

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

modules/oadp-gcp-wif-cloud-authentication.adoc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ ccoctl gcp create-service-accounts --name=<name> \
8080
--workload-identity-provider=<provider-id>
8181
----
8282
+
83-
. Use the ccoctl reference to generate `manifests/openshift-adp-cloud-credentials-gcp-credentials.yaml` to use in the following step.
83+
. The `manifests/openshift-adp-cloud-credentials-gcp-credentials.yaml` is now available to use in the following step.
8484
+
8585
. Apply the credentials secret to the openshift-adp namespace
8686
+
@@ -89,7 +89,6 @@ ccoctl gcp create-service-accounts --name=<name> \
8989
oc create namespace openshift-adp
9090
oc apply -f manifests/openshift-adp-cloud-credentials-gcp-credentials.yaml
9191
----
92-
+
93-
. Generate a token...?
92+
9493
9594

modules/oadp-installing-dpa.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ spec:
189189
<2> Specify how many minutes to wait for several Velero resources before timeout occurs, such as Velero CRD availability, volumeSnapshot deletion, and backup repository availability. The default is 10m.
190190
<3> Set this value to `false` if you want to disable the Restic installation. Restic deploys a daemon set, which means that Restic pods run on each working node. In OADP version 1.2 and later, you can configure Restic for backups by adding `spec.defaultVolumesToFsBackup: true` to the `Backup` CR. In OADP version 1.1, add `spec.defaultVolumesToRestic: true` to the `Backup` CR.
191191
<4> Specify on which nodes Restic is available. By default, Restic runs on all nodes.
192-
<5> For Google WIF cloud authentication use `service_account.json`.
192+
<5> For Google WIF cloud authentication use the `service_account.json`, which is `cloud-credentials-gcp`.
193193
<6> If you do not specify this value, the default name, `{credentials}`, is used. If you specify a custom name, the custom name is used for the backup location.
194194
<7> Specify a bucket as the backup storage location. If the bucket is not a dedicated bucket for Velero backups, you must specify a prefix.
195195
<8> Specify a prefix for Velero backups, for example, `velero`, if the bucket is used for multiple purposes.

0 commit comments

Comments
 (0)