Merge pull request #18 from CareMessagePlatform/bc_072

 Fixed issue where updated snapshots would have missing nodes

Author: bruno-campos

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## [v0.7.2]
+
+### Fixed
+- Fixed issue where updated snapshots would have missing nodes
+
 ## [v0.7.1]
 
 ### Fixed

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rspec-request_snapshot (0.7.1)
+    rspec-request_snapshot (0.7.2)
       rspec (~> 3.0)
 
 GEM

lib/rspec/request_snapshot/updaters/json.rb

@@ -25,13 +25,13 @@ def deep_update_hash(expected_json, stored_json)
     keys = expected_json.keys | stored_json.keys
     keys.each do |key|
       # If key present on expected and not stored, add it to stored
-      if stored_json[key].nil?
+      unless stored_json.key?(key)
         stored_json[key] = expected_json[key]
         next
       end
 
       # If key only present on stored, remove it from stored
-      if expected_json[key].nil?
+      unless expected_json.key?(key)
         stored_json.delete(key)
         next
       end

lib/rspec/request_snapshot/version.rb

@@ -3,7 +3,7 @@
 # rubocop:disable Style/ClassAndModuleChildren
 module Rspec
   module RequestSnapshot
-    VERSION = "0.7.1"
+    VERSION = "0.7.2"
   end
 end
 # rubocop:enable Style/ClassAndModuleChildren

spec/fixtures/snapshots/updaters/null_json.json

@@ -0,0 +1,9 @@
+{
+  "object": {
+    "book": {
+      "id": 1,
+      "name": "Name",
+      "created_at": "2019-06-10T12:25:20-07:00"
+    }
+  }
+}

spec/rspec/updaters_spec.rb

@@ -28,6 +28,18 @@
       end
     end
 
+    context "when updating hash elements that contain nil on actual" do
+      let(:snapshot_name) { "updaters/null_json" }
+      let(:json) { { object: { book: { id: 10, name: "Name changed", created_at: nil } } }.to_json }
+
+      it "updates snapshot node value" do
+        expected_json = JSON.pretty_generate(
+          object: { book: { id: 1, name: "Name changed", created_at: "2019-06-10T12:25:20-07:00" } }
+        )
+        expect(File.read(snapshot_path)).to eq(expected_json)
+      end
+    end
+
     context "when adding a new node" do
       let(:snapshot_name) { "updaters/add_json" }
       let(:json) { { object: { book: { id: 10, name: "Name changed", value: 29.99 } } }.to_json }