You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem faced
GUI user cannot list, delete, update or add a new connector to trino.
Solution proposed
Because we are modifying on top of upstream's /superset-frontend directory, let's use the topic branch approach on nika branch to make sure we can get latest update from upstream and maintain our proprietary features at the same time. Learn more about topic branch
Note: never modify master branch!!!
Backend has a separate WIP issue
1. add a new header nav in superset under Data called Data source
Data source is a new page under screenshot below that allows user to add trino connector, it should be a list format that has:
2.1. List all connectors and associated params
2.2. Delete button for each existing connector
2.3. Modify button for each existing connector to open edit modal
2.4. a test connection button
2.5. A separate button for opening a modal to create a new connector with the following features. See last screenshot for example.
2.5.1. a dropdown for selection of trino connector type (focus on mysql, postgresql and minIO first because they are easier to configure)
2.5.2. parameter fields that are different for different trino connector types
2.5.3. Gsheet should allow user upload a json file as credentials
2.5.4. a save button that closes the modal and refreshes page
2.5.5 preview json for google sheet credentials
2.6 Error dialogue show as a pop up only disappear after click to close
Reviewer Action
test locally all the features above
test in K8s cluster
Alternative solutions
Maintain a new github react repo for the same page.
The text was updated successfully, but these errors were encountered:
@dlworldpeace
1.LISTING: are the fields shown in screenshot 1 are the variables need to show for each item? What is AQE stands for, what is DML stands for, are the variables passed when create the connector or generated by backend when we create the connector?
2.For create connector modal, Other than a dropdown list for select connector type, any other input? For test button, are we calling an api for test or? how should the test result shown?
3. what are parameter fields for mysql, postgresql and mimlo while creating the connector?
4.(I am a bit confusing, we will have different connectors for mysql, or for mysql we will only has one connector which is mysql connector? i am confusing about the term of connector here. )))
are the fields shown in screenshot 1 are the variables need to show for each item?
nope, Trino connectors have their own fields depending on connector types. Please read trino doc to understand.
see 1, each connector type is different. E.g. Mysql Connector needs connection-url, connection-user and connection password according to trino doc
see 2 for e.g.. On top of all these, please also have a catalog-name field for each new trino connector regardless of type. this should be the globally unique identifier that user defines.
user might have different connectors for mysql with different catalog-name, while they might also have many connectors of other type.
Problem faced
GUI user cannot list, delete, update or add a new connector to trino.
Solution proposed
Because we are modifying on top of upstream's /superset-frontend directory, let's use the topic branch approach on
nika
branch to make sure we can get latest update from upstream and maintain our proprietary features at the same time. Learn more about topic branchNote: never modify
master
branch!!!Backend has a separate WIP issue
Data
calledData source
2.5. A separate button for opening a modal to create a new connector with the following features. See last screenshot for example.
Reviewer Action
Alternative solutions
Maintain a new github react repo for the same page.
The text was updated successfully, but these errors were encountered: