Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor theme inconsistencies #220

Open
s1nnohlakes opened this issue Sep 21, 2024 · 14 comments
Open

Minor theme inconsistencies #220

s1nnohlakes opened this issue Sep 21, 2024 · 14 comments

Comments

@s1nnohlakes
Copy link

s1nnohlakes commented Sep 21, 2024

Found some minor theme inconsistencies throughout.

Bug Image
Notes box is not styled properly [✅ FIXED] image
App authorization page left unstyled / broken image
Discord Shop partially broken / unstyled image
Search carousel partially unstyled [✅ FIXED] image
Pinned messages carousel has this weird line at the bottom of the title (not sure if it was intentional but it doesn't fit) [✅ FIXED] image
Emoji title headers cuts off Nitro gradient in the emoji picker [✅ FIXED] image
Server images in emoji picker are slightly cut off [✅ FIXED] image
Nitro gift page has been broken for a while now [✅ FIXED] image
@CapnKitten
Copy link
Owner

All but the Discord shop are fixed; that's the new layout that isn't out for everyone yet. The authorization modal won't be styled right away.

@s1nnohlakes
Copy link
Author

s1nnohlakes commented Sep 21, 2024

Alright, thanks for your work! I forgot to include one weird bug that has been happening since about a few weeks ago or so, and one other inconsistency.

Weirdly, when you're typing a message in a DM, and it happens to be long enough, the chat box starts to weirdly affect and resize other elements around. I don't think this is intentional behavior, as this doesn't happen normally. It only happens on DMs, not on servers.

Video reproducing the bug:

Screen.Recording.2024-09-21.194939.mp4

Some text boxes throughout the UI are not styled properly:
image
image
image
image
image

@CapnKitten
Copy link
Owner

CapnKitten commented Sep 22, 2024

The weird DM profile issue will be fixed. As for the input fields, those are properly styled using the filled style of MD3. I chose the filled style because not all of the input fields have labels for the animation. I try to follow MD3 as closely as possible and you can see the components here directly from Google.

@s1nnohlakes
Copy link
Author

Ah I see, I see. I suppose I didn't take that in mind, my apologies.

@s1nnohlakes
Copy link
Author

One more thing, the apps picker dialog isn't really properly styled either (or at least a part of it)
image

@CapnKitten
Copy link
Owner

Fix for that is now live.

@s1nnohlakes
Copy link
Author

Found another inconsistency; these two elements don't have the same size.
image

@CapnKitten
Copy link
Owner

Fix is live.

@s1nnohlakes
Copy link
Author

Another one that came up recently; weird behaviors with the new message context modal (not sure if this is out for everyone)

With theme installed:

Screen.Recording.2024-09-28.162517.mp4

Intended behavior (Without theme):

Screen.Recording.2024-09-28.162107.mp4

@CapnKitten
Copy link
Owner

Ah yea, that was recently updated by Discord. Fix live.

@s1nnohlakes
Copy link
Author

s1nnohlakes commented Oct 1, 2024

Looks like Discord made some changes, here are the latest bugs I've found so far.
image
image
image
image
image
image
image

Also, not sure if this is intentional, but the Nitro page, when opened on the DMs page, has a gray background (which doesn't really fit as opening the Nitro page in settings reveals a dark background instead.
image

@s1nnohlakes
Copy link
Author

Update: Now the "Add Status" button is broken as well.
image

@CapnKitten
Copy link
Owner

That was fixed 3 days ago.

@s1nnohlakes
Copy link
Author

The Add Status button still seems to be unfixed on my side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants