don't close camera during countdown

[Brendonovich]

Summary by CodeRabbit

• New Features

  • Improved handling of recording states with explicit support for "pending" and "active" recording statuses.

• Refactor

  • Updated all recording-related actions to use new methods for managing and accessing the current recording state.

• Style

  • Enhanced type definitions for recordings, making the platform property optional for better flexibility.

• Bug Fixes

  • Ensured consistent closing of occluder windows when clearing recordings.

[coderabbitai]

Walkthrough

The changes introduce a new RecordingState enum in the Rust backend to explicitly represent recording states (none, pending, active), refactor all related logic to use this enum, and update method signatures accordingly. Type definitions in the frontend are also updated to make the platform property optional in recording metadata types.

Changes

Cohort / File(s)	Change Summary
Recording State Refactor (Rust Backend) apps/desktop/src-tauri/src/lib.rs	Replaces Option<InProgressRecording> with a RecordingState enum in the App struct; adds/updates methods for managing and querying recording state; updates all usages to use new enum and methods.
Recording Flow Adjustments (Rust Backend) apps/desktop/src-tauri/src/recording.rs	Updates recording control functions to use new RecordingState methods; adds pending state logic in start_recording; updates how mutable references and clearing are handled.
Type Definition Update (Frontend TypeScript) apps/desktop/src/utils/tauri.ts	Changes RecordingMeta and RecordingMetaWithType type definitions to make the platform property optional (was required and nullable, now optional and nullable).

Sequence Diagram(s)

sequenceDiagram
    participant UI
    participant App (Rust)
    participant RecordingState

    UI->>App (Rust): Start Recording
    App (Rust)->>RecordingState: set_pending_recording()
    App (Rust)->>UI: Close main window, start countdown
    UI->>App (Rust): Countdown finished
    App (Rust)->>RecordingState: set_current_recording()
    Note right of RecordingState: State becomes Active(InProgressRecording)
    UI->>App (Rust): Pause/Resume/End Recording
    App (Rust)->>RecordingState: current_recording_mut() / clear_current_recording()

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Poem

In burrows deep, the states now bloom—
None, Pending, Active, each with room.
Rusty enum, logic neat,
Typescript’s tweak makes change complete.
The platform’s shy, it may not show,
But rabbits know which way to go!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b402cee and 9306da4.

📒 Files selected for processing (3)

• apps/desktop/src-tauri/src/lib.rs (8 hunks)
• apps/desktop/src-tauri/src/recording.rs (5 hunks)
• apps/desktop/src/utils/tauri.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Build Desktop (x86_64-pc-windows-msvc, windows-latest)
• GitHub Check: Build Desktop (aarch64-apple-darwin, macos-latest)
• GitHub Check: Clippy

🔇 Additional comments (16)

apps/desktop/src/utils/tauri.ts (1)

386-387: LGTM! Type change supports flexible metadata during recording lifecycle.

Making the platform property optional aligns well with the introduction of the pending recording state. This allows metadata to be gradually populated as recordings progress through different states (pending → active → completed).

Since this is an auto-generated file, the change originates from the Rust backend type definitions, ensuring type safety across the frontend-backend boundary.

apps/desktop/src-tauri/src/recording.rs (5)

195-195: LGTM! Debug derive improves debugging capabilities.

Adding Debug derive to StartRecordingInputs will help with logging and troubleshooting recording-related issues.

---

330-335: Excellent! This change directly addresses the PR objective.

Setting the recording state to pending before closing the main window and starting countdown ensures the camera stays open during the countdown period. The explicit state management prevents premature cleanup of recording resources.

The lock scope is properly managed with the block structure, ensuring the write lock is released promptly.

---

505-505: Good refactoring to use accessor methods.

Using current_recording_mut() instead of direct field access improves encapsulation and allows the internal RecordingState enum representation to be properly managed.

---

517-517: Consistent with the new accessor pattern.

Same improvement as in pause_recording - using the proper accessor method for the refactored recording state management.

---

604-604: Proper encapsulation of recording cleanup.

Using clear_current_recording() ensures consistent cleanup behavior, including closing occluder windows and properly managing the RecordingState enum transitions.

apps/desktop/src-tauri/src/lib.rs (10)

88-92: Excellent enum design for explicit state management.

The RecordingState enum provides clear, type-safe representation of recording states. The Pending variant directly addresses the PR objective of maintaining camera state during countdown, which is a significant improvement over the previous Option<InProgressRecording> approach.

---

113-113: LGTM!

The field type change from Option<InProgressRecording> to RecordingState is correct and maintains the existing serialization behavior.

---

149-152: Well-implemented method for pending state.

The set_pending_recording method correctly sets the state to Pending and emits the appropriate event. This is key to the PR's objective of maintaining camera state during recording countdown.

---

154-157: LGTM!

The method correctly wraps the recording in RecordingState::Active while maintaining the same external interface and event emission behavior.

---

159-170: Robust implementation with proper cleanup.

The method correctly uses pattern matching to handle all RecordingState variants. The logic ensures occluder windows are always closed regardless of the previous state, which is important for proper cleanup. The return value maintains backward compatibility by only returning Some(recording) for the Active variant.

---

196-208: Well-designed accessor methods.

Both current_recording and current_recording_mut provide clean, safe access to active recordings. The pattern matching correctly returns None for both None and Pending states, ensuring callers only get access to truly active recordings.

---

210-212: Efficient boolean check for recording activity.

The method efficiently uses the matches! macro to determine if recording is in any active state. The descriptive name clearly indicates its purpose for checking both active and pending states.

---

427-427: LGTM!

Correctly updated to use the new current_recording() accessor method while maintaining the same external API behavior.

---

2168-2168: Critical change supporting the PR objective.

The condition correctly uses is_recording_active_or_pending() to prevent clearing camera and mic feeds during pending states. This directly implements the "don't close camera during countdown" requirement.

---

2079-2079: LGTM!

Properly initializes the recording state to RecordingState::None, maintaining the same initial behavior as the previous Option implementation.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch countdown-camera-fix

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.