web: fix displaying name of video creator + pro status #1315

ameer2468 · 2025-10-29T19:52:17Z

Summary by CodeRabbit

Bug Fixes

Corrected video owner name display in the share header
Fixed pro status indicator attribution for video owners

coderabbitai · 2025-10-29T19:52:45Z

Walkthrough

These changes refactor owner information handling and attribution display in the video share page. Unused imports are removed from Share.tsx, the author attribution in ShareHeader is corrected from data.name to data.owner.name, and a computed ownerIsPro variable is introduced in page.tsx to streamline pro status propagation.

Changes

Cohort / File(s)	Summary
Import cleanup `apps/web/app/s/[videoId]/Share.tsx`	Removed unused imports (`userSelectProps`, `videos`) from database schema; retained `commentsSchema`.
Owner attribution display `apps/web/app/s/[videoId]/_components/ShareHeader.tsx`	Changed author name display from `data.name` to `data.owner.name` in the header component.
Owner pro status computation `apps/web/app/s/[videoId]/page.tsx`	Introduced local `ownerIsPro` variable computed from `userIsPro(video.owner)`; replaced inline calls with variable reference; added `ownerIsPro` to returned `videoWithOrganizationInfo` object.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Data flow verification: Confirm ownerIsPro computation and propagation is correct across page → Share → ShareHeader
Owner object structure: Validate that data.owner.name access in ShareHeader is properly typed and doesn't introduce null/undefined risks
Import impact: Verify that removed imports are truly unused and no transitive dependencies are affected

Possibly related PRs

fix: video owner check pro status #1260: Updates ShareHeader component to accept and prefer an ownerIsPro field, aligning with the main PR's pro status refactoring.
chore: improve the resilience of checking #1242: Modifies ShareHeader component owner/author information handling, overlapping with attribution display changes.
web: re-arrange cap card buttons, share page show owner, and more... #1156: Adjusts how video owner data is sourced and displayed across share page components.

Poem

🐰 The owner's name now shines with proper nested delight,
Pro status flows downstream, computed just right,
Unused imports tidied away without a fuss,
Attribution refined—a cleaner share for us! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "web: fix displaying name of video creator + pro status" accurately reflects the substantive changes in the changeset. The PR modifies ShareHeader.tsx to display the correct creator name from `data.owner.name` instead of `data.name`, and updates page.tsx to properly compute and include the owner's pro status using a dedicated `ownerIsPro` variable. The title is clear, specific, and uses descriptive terminology that directly corresponds to the actual fixes implemented, making it easy for reviewers to understand the primary intent of the changes.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix-display-video-creator-name

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 875a6a3 and dbd8db9.

📒 Files selected for processing (3)

apps/web/app/s/[videoId]/Share.tsx (1 hunks)
apps/web/app/s/[videoId]/_components/ShareHeader.tsx (1 hunks)
apps/web/app/s/[videoId]/page.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (5)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx}: Use a 2-space indent for TypeScript code.
Use Biome for formatting and linting TypeScript/JavaScript files by running pnpm format.

Use strict TypeScript and avoid any; leverage shared types

Files:

apps/web/app/s/[videoId]/Share.tsx
apps/web/app/s/[videoId]/page.tsx
apps/web/app/s/[videoId]/_components/ShareHeader.tsx

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,js,jsx}: Use kebab-case for filenames for TypeScript/JavaScript modules (e.g., user-menu.tsx).
Use PascalCase for React/Solid components.

Files:

apps/web/app/s/[videoId]/Share.tsx
apps/web/app/s/[videoId]/page.tsx
apps/web/app/s/[videoId]/_components/ShareHeader.tsx

apps/web/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

On the client, always use useEffectQuery or useEffectMutation from @/lib/EffectRuntime; never call EffectRuntime.run* directly in components.

Files:

apps/web/app/s/[videoId]/Share.tsx
apps/web/app/s/[videoId]/page.tsx
apps/web/app/s/[videoId]/_components/ShareHeader.tsx

apps/web/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

apps/web/**/*.{ts,tsx}: Use TanStack Query v5 for all client-side server state and fetching in the web app
Mutations should call Server Actions directly and perform targeted cache updates with setQueryData/setQueriesData
Run server-side effects via the ManagedRuntime from apps/web/lib/server.ts using EffectRuntime.runPromise/runPromiseExit; do not create runtimes ad hoc
Client code should use helpers from apps/web/lib/EffectRuntime.ts (useEffectQuery, useEffectMutation, useRpcClient); never call ManagedRuntime.make inside components

Files:

apps/web/app/s/[videoId]/Share.tsx
apps/web/app/s/[videoId]/page.tsx
apps/web/app/s/[videoId]/_components/ShareHeader.tsx

apps/web/app/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Server components needing Effect services must call EffectRuntime.runPromise(effect.pipe(provideOptionalAuth))

Files:

apps/web/app/s/[videoId]/Share.tsx
apps/web/app/s/[videoId]/page.tsx
apps/web/app/s/[videoId]/_components/ShareHeader.tsx

🧠 Learnings (5)

📚 Learning: 2025-10-14T10:15:44.019Z

Learnt from: CR
PR: CapSoftware/Cap#0
File: CLAUDE.md:0-0
Timestamp: 2025-10-14T10:15:44.019Z
Learning: Applies to **/*.{ts,tsx} : Use strict TypeScript and avoid any; leverage shared types

Applied to files:

apps/web/app/s/[videoId]/Share.tsx

📚 Learning: 2025-09-22T14:19:56.010Z

Learnt from: CR
PR: CapSoftware/Cap#0
File: AGENTS.md:0-0
Timestamp: 2025-09-22T14:19:56.010Z
Learning: Applies to **/queries.ts : Do not edit auto-generated files named `queries.ts`.

Applied to files:

apps/web/app/s/[videoId]/Share.tsx

📚 Learning: 2025-10-14T10:15:44.019Z

Learnt from: CR
PR: CapSoftware/Cap#0
File: CLAUDE.md:0-0
Timestamp: 2025-10-14T10:15:44.019Z
Learning: Applies to apps/desktop/src/**/*.{ts,tsx} : Use tanstack/solid-query for server state in the desktop app

Applied to files:

apps/web/app/s/[videoId]/Share.tsx

📚 Learning: 2025-10-14T10:15:44.019Z

Learnt from: CR
PR: CapSoftware/Cap#0
File: CLAUDE.md:0-0
Timestamp: 2025-10-14T10:15:44.019Z
Learning: Applies to apps/web/**/*.{ts,tsx} : Use TanStack Query v5 for all client-side server state and fetching in the web app

Applied to files:

apps/web/app/s/[videoId]/Share.tsx

📚 Learning: 2025-10-14T10:15:44.019Z

Learnt from: CR
PR: CapSoftware/Cap#0
File: CLAUDE.md:0-0
Timestamp: 2025-10-14T10:15:44.019Z
Learning: Applies to **/queries.ts : NEVER EDIT auto-generated query bindings file: queries.ts

Applied to files:

apps/web/app/s/[videoId]/Share.tsx

🧬 Code graph analysis (1)

apps/web/app/s/[videoId]/page.tsx (1)

packages/utils/src/constants/plans.ts (1)

userIsPro (14-38)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Build Desktop (x86_64-pc-windows-msvc, windows-latest)
GitHub Check: Build Desktop (aarch64-apple-darwin, macos-latest)
GitHub Check: Analyze (rust)

🔇 Additional comments (3)

apps/web/app/s/[videoId]/_components/ShareHeader.tsx (1)

245-245: LGTM! Correctly displays owner name.

This fix correctly displays the video owner's name (data.owner.name) instead of the video name (data.name) for author attribution, which aligns with the PR objective.

apps/web/app/s/[videoId]/page.tsx (1)

723-735: LGTM! Good refactor of owner pro status computation.

Extracting ownerIsPro into a local variable avoids redundant calls to userIsPro(video.owner) and makes the pro status computation explicit. The addition of the top-level ownerIsPro field ensures consistent pro status propagation to consuming components, which aligns with the PR objective.

apps/web/app/s/[videoId]/Share.tsx (1)

3-3: LGTM! Good cleanup of unused imports.

Removing unused imports (userSelectProps and videos) while retaining only the necessary commentsSchema type improves code maintainability and reduces unnecessary coupling to the database schema module.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ameer2468 added 2 commits October 29, 2025 22:48

Update ShareHeader.tsx

3e8657c

fix isOwnerPro value

dbd8db9

ameer2468 merged commit b6d21f5 into main Oct 29, 2025
16 checks passed

ameer2468 deleted the fix-display-video-creator-name branch October 29, 2025 19:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

web: fix displaying name of video creator + pro status #1315

web: fix displaying name of video creator + pro status #1315

Uh oh!

ameer2468 commented Oct 29, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

web: fix displaying name of video creator + pro status #1315

web: fix displaying name of video creator + pro status #1315

Uh oh!

Conversation

ameer2468 commented Oct 29, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Bug Fixes

Uh oh!

coderabbitai bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks and finishing touches

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ameer2468 commented Oct 29, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 29, 2025 •

edited

Loading