fix: dashboard fast refresh #1011
Conversation
WalkthroughRemoved the exported navItemClass constant and its imports across dashboard/navbar components, inlining equivalent Tailwind class strings where used. Minor key string formatting adjusted in AdminNavItems. No new logic, control flow, or error handling introduced. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
apps/web/app/(org)/dashboard/_components/Navbar/SpacesList.tsx (1)
175-184: Inline base classes are fine; add focus-visible styles for a11y
outline-noneremoves keyboard focus indication. Add a focus-visible ring so links remain keyboard-accessible.- "flex items-center justify-start rounded-xl outline-none tracking-tight overflow-hidden", + "flex items-center justify-start rounded-xl outline-none tracking-tight overflow-hidden focus-visible:ring-2 focus-visible:ring-gray-8",apps/web/app/(org)/dashboard/_components/Navbar/Items.tsx (2)
191-191: Use a stable, unique key (id) instead of nameNames can collide or change, causing remounts and UI flicker. Prefer the organization id.
- key={`${organization.organization.name}-organization`} + key={organization.organization.id}
436-437: Add focus-visible styles and confirm navItemClass removalAdd a visible keyboard focus style to offset
outline-none; confirmed no occurrences ofnavItemClassremain in .ts/.tsx/.js/.jsx.File: apps/web/app/(org)/dashboard/_components/Navbar/Items.tsx (around line 436)
- "flex overflow-hidden justify-start items-center tracking-tight rounded-xl outline-none", + "flex overflow-hidden justify-start items-center tracking-tight rounded-xl outline-none focus-visible:ring-2 focus-visible:ring-gray-8",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/web/app/(org)/dashboard/_components/DashboardInner.tsx(0 hunks)apps/web/app/(org)/dashboard/_components/Navbar/Items.tsx(2 hunks)apps/web/app/(org)/dashboard/_components/Navbar/SpacesList.tsx(1 hunks)
💤 Files with no reviewable changes (1)
- apps/web/app/(org)/dashboard/_components/DashboardInner.tsx
🧰 Additional context used
📓 Path-based instructions (4)
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TanStack Query v5 for client-side server state and data fetching in the web app
Mutations should call Server Actions and perform precise cache updates with setQueryData/setQueriesData, avoiding broad invalidations
Prefer Server Components for initial data and pass initialData to client components for React Query hydration
Files:
apps/web/app/(org)/dashboard/_components/Navbar/SpacesList.tsxapps/web/app/(org)/dashboard/_components/Navbar/Items.tsx
{apps/web,packages/ui}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
{apps/web,packages/ui}/**/*.{ts,tsx}: Use Tailwind CSS exclusively for styling in the web app and shared React UI components
Component naming: React components in PascalCase; hooks in camelCase starting with 'use'
Files:
apps/web/app/(org)/dashboard/_components/Navbar/SpacesList.tsxapps/web/app/(org)/dashboard/_components/Navbar/Items.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Use strict TypeScript and avoid any; prefer shared types from packages
**/*.{ts,tsx}: Use Biome to format/lint TypeScript with a 2-space indent
TypeScript file names should be kebab-case (e.g., user-menu.tsx)
Files:
apps/web/app/(org)/dashboard/_components/Navbar/SpacesList.tsxapps/web/app/(org)/dashboard/_components/Navbar/Items.tsx
**/*.{tsx,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
React/Solid components should be named using PascalCase
Files:
apps/web/app/(org)/dashboard/_components/Navbar/SpacesList.tsxapps/web/app/(org)/dashboard/_components/Navbar/Items.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build Desktop (aarch64-apple-darwin, macos-latest)
- GitHub Check: Build Desktop (x86_64-pc-windows-msvc, windows-latest)
- GitHub Check: Analyze (rust)
Summary by CodeRabbit