Skip to content

Commit 6fa5d81

Browse files
authored
Fix layout and scroll issues (#530)
1 parent e325e1d commit 6fa5d81

File tree

7 files changed

+19
-21
lines changed

7 files changed

+19
-21
lines changed

apps/web/app/dashboard/_components/DashboardInner.tsx

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,16 @@ export default function DashboardInner({
4646
const title = titles[pathname] || "";
4747
const { theme, setThemeHandler } = useTheme();
4848
return (
49-
<div className="flex flex-col w-full h-full">
49+
<>
5050
{/* Top Bar - Fixed at top with proper z-index */}
5151
<header
5252
className={clsx(
53-
"flex sticky z-50 justify-between items-center px-5 mt-10 w-full h-16 border-b bg-gray-1 lg:bg-transparent border-gray-3 lg:border-b-0 lg:pl-0 lg:pr-5 lg:top-0 lg:relative top-[64px] lg:mt-5 lg:h-8"
53+
"flex sticky z-50 justify-between items-center px-5 mt-10 w-full border-b min-h-16 md:min-h-10 bg-gray-1 lg:bg-transparent border-gray-3 lg:border-b-0 lg:pl-0 lg:pr-5 lg:top-0 lg:relative top-[64px] lg:mt-5 lg:h-8"
5454
)}
5555
>
56-
<p className="relative text-xl truncate text-gray-12 lg:text-2xl w-fit max-w-[150px]">{title}</p>
56+
<p className="relative text-xl truncate md:max-w-full text-gray-12 lg:text-2xl w-fit max-w-[150px]">
57+
{title}
58+
</p>
5759
<div className="flex gap-4 items-center">
5860
<div
5961
onClick={() => {
@@ -71,14 +73,13 @@ export default function DashboardInner({
7173
</header>
7274
{/* Content Area - Scrollable content with proper spacing */}
7375
<main
74-
className={clsx(
75-
"flex overflow-y-auto flex-col flex-1 p-5 pb-5 border border-b-0 bg-gray-1 border-gray-3 lg:rounded-tl-2xl lg:p-8",
76-
"mt-5 min-h-screen"
77-
)}
76+
className={
77+
"flex flex-col flex-1 p-5 pb-5 mt-5 border border-b-0 min-h-fit bg-gray-1 border-gray-3 lg:rounded-tl-2xl lg:p-8"
78+
}
7879
>
79-
<div className="flex flex-col gap-4">{children}</div>
80+
<div className="flex flex-col flex-1 gap-4">{children}</div>
8081
</main>
81-
</div>
82+
</>
8283
);
8384
}
8485

apps/web/app/dashboard/_components/DynamicSharedLayout.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export default function DynamicSharedLayout({
9999
</aside>
100100
{/* Header/topbar is now expected to be rendered by children if needed */}
101101
{/* Main content area */}
102-
<div className="overflow-y-auto col-span-1 row-span-2 custom-scroll focus:outline-none">
102+
<div className="flex col-span-1 row-span-2 h-full custom-scroll focus:outline-none">
103103
<AdminMobileNav />
104104
{children}
105105
</div>

apps/web/app/dashboard/layout.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,9 +168,7 @@ export default async function DashboardLayout({
168168
initialTheme={theme as "light" | "dark"}
169169
initialSidebarCollapsed={sidebar === "true"}
170170
>
171-
<div className="full-layout">
172-
<DashboardTemplate>{children}</DashboardTemplate>
173-
</div>
171+
<DashboardTemplate>{children}</DashboardTemplate>
174172
</DynamicSharedLayout>
175173
);
176174
}

apps/web/app/dashboard/settings/organization/Organization.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export const Organization = () => {
9696

9797
<SeatsInfoCards />
9898

99-
<div className="flex flex-col flex-1 gap-6 justify-center items-stretch xl:flex-row">
99+
<div className="flex flex-col gap-6 justify-center items-stretch xl:flex-row">
100100
<OrganizationDetailsCard
101101
isOwner={isOwner}
102102
saveLoading={saveLoading}

apps/web/app/dashboard/settings/organization/components/CustomDomainIconCard.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ export const CustomDomainIconCard = ({
1515
}: CustomDomainCardProps) => {
1616
return (
1717
<Card className="flex flex-col flex-1 gap-6 w-full lg:flex-row">
18-
<div className="flex-1 order-first lg:order-last">
18+
<div className="order-first lg:order-last">
1919
<OrganizationIcon isOwner={isOwner} showOwnerToast={showOwnerToast} />
2020
</div>
21-
<div className="flex-1 order-last lg:order-first">
21+
<div className="order-last lg:order-first">
2222
<div className="space-y-1">
2323
<Label htmlFor="customDomain">Custom Domain</Label>
2424
<CardDescription className="w-full max-w-[400px]">

apps/web/app/dashboard/settings/organization/components/OrganizationIcon.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export const OrganizationIcon = ({
6767
};
6868

6969
return (
70-
<div className="relative flex-1">
70+
<div className="flex-1">
7171
<div className="space-y-1">
7272
<Label htmlFor="icon">Organization Icon</Label>
7373
<CardDescription className="w-full max-w-[400px]">

apps/web/app/globals.css

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,7 @@ ul {
446446
} */
447447

448448
.dashboard-page {
449-
@apply flex flex-col;
449+
@apply flex overflow-auto flex-col flex-1 items-stretch custom-scroll;
450450
}
451451

452452
.dashboard-header {
@@ -476,17 +476,16 @@ slot:not(.dashboard-layout slot) {
476476

477477
/* Custom scrollbar */
478478
.custom-scroll {
479-
margin-right: 3px; /* Add margin to create space between scrollbar and window edge */
480479
overflow-y: scroll;
481480
}
482481

483482
.custom-scroll::-webkit-scrollbar {
484-
width: 7px;
483+
width: 3px;
485484
background-color: transparent;
486485
}
487486

488487
.custom-scroll::-webkit-scrollbar-thumb {
489-
@apply bg-gray-7 w-[7px] rounded-full;
488+
@apply bg-gray-7 w-[3px] rounded-full;
490489
}
491490

492491
#scrolling-section slot {

0 commit comments

Comments
 (0)