more cleanup

Author: ameer2468

apps/web/app/dashboard/_components/Notifications/FilterTabs.tsx

@@ -63,7 +63,9 @@ export const FilterTabs = ({ activeFilter, setActiveFilter, loading, count }: Fi
                   ? "text-gray-12"
                   : "text-gray-10 group-hover:text-gray-11"
               )}>
-                {filter === FilterType.ALL ? totalCount : count?.[filter.toLowerCase() as keyof typeof count]}
+                {filter === FilterType.ALL
+                  ? totalCount
+                  : count?.[filter.toLowerCase() as NotificationType] ?? 0}
               </p>}
             </div>
           </div>

apps/web/app/dashboard/_components/Notifications/NotificationItem.tsx

@@ -19,7 +19,15 @@ const descriptionMap: Record<Notification["type"], string> = {
 };
 
 export const NotificationItem = ({ notification, className }: NotificationItemProps) => {
-  const link = notification.type === NotificationType.REPLY || notification.type === NotificationType.COMMENT || notification.type === NotificationType.MENTION || notification.type === NotificationType.REACTION ? `/s/${notification.videoId}/?comment=${notification.data.comment?.id}` : `/s/${notification.videoId}`;
+  const commentTypes = [
+    NotificationType.REPLY,
+    NotificationType.COMMENT,
+    NotificationType.REACTION
+  ];
+  const commentId = notification.data?.comment?.id;
+  const link = commentTypes.includes(notification.type) && commentId
+    ? `/s/${notification.videoId}/?comment=${commentId}`
+    : `/s/${notification.videoId}`;
 
   return (
     <Link href={link}>