Skip to content

Commit 0bcc9ea

Browse files
authored
fix: timeline selection ui (#1348)
* Update ConfigSidebar.tsx * Update Header.tsx
1 parent a91f8c4 commit 0bcc9ea

File tree

2 files changed

+21
-13
lines changed

2 files changed

+21
-13
lines changed

apps/desktop/src/routes/editor/ConfigSidebar.tsx

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,9 @@ export function ConfigSidebar() {
333333
"--margin-top-scroll": "5px",
334334
}}
335335
class="custom-scroll overflow-x-hidden overflow-y-scroll text-[0.875rem] flex-1 min-h-0"
336+
classList={{
337+
hidden: !!editorState.timeline.selection,
338+
}}
336339
>
337340
<BackgroundConfig scrollRef={scrollRef} />
338341
<CameraConfig scrollRef={scrollRef} />
@@ -645,14 +648,19 @@ export function ConfigSidebar() {
645648
<CaptionsTab />
646649
</KTabs.Content>
647650
</div>
648-
<Show when={editorState.timeline.selection}>
649-
{(selection) => (
650-
<div
651-
style={{
652-
"--margin-top-scroll": "5px",
653-
}}
654-
class="absolute custom-scroll p-5 top-16 left-0 right-0 bottom-0 text-[0.875rem] space-y-4 bg-gray-1 dark:bg-gray-2 z-50 animate-in slide-in-from-bottom-2 fade-in"
655-
>
651+
<div
652+
style={{
653+
"--margin-top-scroll": "5px",
654+
}}
655+
class="custom-scroll p-5 top-16 left-0 right-0 bottom-0 text-[0.875rem] space-y-4 bg-gray-1 dark:bg-gray-2 z-50"
656+
classList={{
657+
hidden: !editorState.timeline.selection,
658+
"animate-in slide-in-from-bottom-2 fade-in":
659+
!!editorState.timeline.selection,
660+
}}
661+
>
662+
<Show when={editorState.timeline.selection}>
663+
{(selection) => (
656664
<Suspense>
657665
<Show
658666
when={(() => {
@@ -872,9 +880,9 @@ export function ConfigSidebar() {
872880
)}
873881
</Show>
874882
</Suspense>
875-
</div>
876-
)}
877-
</Show>
883+
)}
884+
</Show>
885+
</div>
878886
</KTabs>
879887
);
880888
}

apps/desktop/src/routes/editor/Header.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,15 +112,15 @@ export function Header() {
112112
}}
113113
tooltipText="Captions"
114114
leftIcon={<IconCapCaptions class="w-5" />}
115-
comingSoon={!editorState.timeline.selection}
115+
comingSoon={true}
116116
/>
117117
<EditorButton
118118
onClick={() => {
119119
if (clearTimelineSelection()) return;
120120
}}
121121
tooltipText="Performance"
122122
leftIcon={<IconCapGauge class="w-[18px]" />}
123-
comingSoon={!editorState.timeline.selection}
123+
comingSoon={true}
124124
/>
125125
</div>
126126

0 commit comments

Comments
 (0)