Skip to content

Allow deleting instant recordings after successful upload #3908

Allow deleting instant recordings after successful upload

Allow deleting instant recordings after successful upload #3908

Triggered via pull request October 14, 2025 19:33
Status Success
Total duration 7m 30s
Artifacts

ci.yml

on: pull_request
Detect Changes
9s
Detect Changes
Typecheck
1m 14s
Typecheck
Format (Biome)
7s
Format (Biome)
Format (Cargo)
9s
Format (Cargo)
Lint (Biome)
15s
Lint (Biome)
Matrix: Build Desktop
Clippy
1m 20s
Clippy
Verify Tauri plugin versions
0s
Verify Tauri plugin versions
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
this `map_or` can be simplified: crates/rendering/src/decoder/avassetreader.rs#L77
warning: this `map_or` can be simplified --> crates/rendering/src/decoder/avassetreader.rs:77:13 | 77 | / self.scratch_spec 78 | | .map_or(true, |(current_format, current_width, current_height)| { 79 | | current_format != format || current_width != width || current_height != height 80 | | }); | |__________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `#[warn(clippy::unnecessary_map_or)]` on by default help: use is_none_or instead | 78 - .map_or(true, |(current_format, current_width, current_height)| { 78 + .is_none_or(|(current_format, current_width, current_height)| { |
unused variable: `check_skip_send`: crates/recording/src/sources/screen_capture/macos.rs#L169
warning: unused variable: `check_skip_send` --> crates/recording/src/sources/screen_capture/macos.rs:169:33 | 169 | ... let check_skip_send = || { | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_check_skip_send`
unused variable: `tasks`: crates/recording/src/output_pipeline/ffmpeg.rs#L42
warning: unused variable: `tasks` --> crates/recording/src/output_pipeline/ffmpeg.rs:42:9 | 42 | tasks: &mut TaskPool, | ^^^^^ help: if this is intentional, prefix it with an underscore: `_tasks` | = note: `#[warn(unused_variables)]` on by default
unneeded `return` statement: crates/enc-ffmpeg/src/video/h264.rs#L194
warning: unneeded `return` statement --> crates/enc-ffmpeg/src/video/h264.rs:194:13 | 194 | return; | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 193 - tracing::error!("Failed to send EOF to encoder: {:?}", e); 194 - return; 193 + tracing::error!("Failed to send EOF to encoder: {:?}", e); |
manual implementation of an assign operation: crates/enc-ffmpeg/src/audio/buffered_resampler.rs#L92
warning: manual implementation of an assign operation --> crates/enc-ffmpeg/src/audio/buffered_resampler.rs:92:13 | 92 | next_pts = next_pts + samples as i64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_pts += samples as i64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: `#[warn(clippy::assign_op_pattern)]` on by default
redundant pattern matching, consider using `is_some()`: crates/enc-ffmpeg/src/audio/buffered_resampler.rs#L78
warning: redundant pattern matching, consider using `is_some()` --> crates/enc-ffmpeg/src/audio/buffered_resampler.rs:78:19 | 78 | while let Some(_) = self.resampler.delay() { | ----------^^^^^^^------------------------- help: try: `while self.resampler.delay().is_some()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
this `if` statement can be collapsed: crates/enc-ffmpeg/src/audio/buffered_resampler.rs#L59
warning: this `if` statement can be collapsed --> crates/enc-ffmpeg/src/audio/buffered_resampler.rs:59:9 | 59 | / if let Some(min_next_pts) = self.min_next_pts { 60 | | if let Some(pts) = frame.pts() { 61 | | frame.set_pts(Some(pts.max(min_next_pts))); 62 | | } 63 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `#[warn(clippy::collapsible_if)]` on by default help: collapse nested if block | 59 ~ if let Some(min_next_pts) = self.min_next_pts 60 ~ && let Some(pts) = frame.pts() { 61 | frame.set_pts(Some(pts.max(min_next_pts))); 62 ~ } |
unneeded `return` statement: crates/enc-ffmpeg/src/audio/buffered_resampler.rs#L51
warning: unneeded `return` statement --> crates/enc-ffmpeg/src/audio/buffered_resampler.rs:51:9 | 51 | return remaining_samples; | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 51 - return remaining_samples; 51 + remaining_samples |
field `config` is never read: crates/enc-ffmpeg/src/video/h264.rs#L145
warning: field `config` is never read --> crates/enc-ffmpeg/src/video/h264.rs:145:5 | 142 | pub struct H264Encoder { | ----------- field in this struct ... 145 | config: VideoInfo, | ^^^^^^ | = note: `#[warn(dead_code)]` on by default
clamp-like pattern without using clamp function: crates/media-info/src/lib.rs#L69
warning: clamp-like pattern without using clamp function --> crates/media-info/src/lib.rs:69:13 | 69 | raw_channels.min(Self::MAX_AUDIO_CHANNELS).max(1) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `raw_channels.clamp(1, Self::MAX_AUDIO_CHANNELS)` | = note: clamp will panic if max < min = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp = note: `#[warn(clippy::manual_clamp)]` on by default