Local upload tracking #3670
ci.yml
on: pull_request
Detect Changes
10s
Typecheck
1m 24s
Format (Biome)
6s
Format (Cargo)
8s
Lint (Biome)
11s
Matrix: Build Desktop
Annotations
10 warnings
|
unused import: `channel::mpsc`:
crates/recording/src/studio_recording.rs#L17
warning: unused import: `channel::mpsc`
--> crates/recording/src/studio_recording.rs:17:27
|
17 | FutureExt, StreamExt, channel::mpsc, future::OptionFuture, stream::FuturesUnordered,
| ^^^^^^^^^^^^^
|
|
unused import: `AudioFrame`:
crates/recording/src/studio_recording.rs#L8
warning: unused import: `AudioFrame`
--> crates/recording/src/studio_recording.rs:8:9
|
8 | AudioFrame, DoneFut, FinishedOutputPipeline, OutputPipeline, PipelineDoneError,
| ^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unneeded `return` statement:
crates/enc-ffmpeg/src/video/h264.rs#L193
warning: unneeded `return` statement
--> crates/enc-ffmpeg/src/video/h264.rs:193:13
|
193 | return;
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
192 - tracing::error!("Failed to send EOF to encoder: {:?}", e);
193 - return;
192 + tracing::error!("Failed to send EOF to encoder: {:?}", e);
|
|
|
unneeded `return` statement:
crates/enc-ffmpeg/src/video/h264.rs#L186
warning: unneeded `return` statement
--> crates/enc-ffmpeg/src/video/h264.rs:186:13
|
186 | return;
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
185 - tracing::error!("Failed to send frame to encoder: {:?}", e);
186 - return;
185 + tracing::error!("Failed to send frame to encoder: {:?}", e);
|
|
|
manual implementation of an assign operation:
crates/enc-ffmpeg/src/audio/buffered_resampler.rs#L92
warning: manual implementation of an assign operation
--> crates/enc-ffmpeg/src/audio/buffered_resampler.rs:92:13
|
92 | next_pts = next_pts + samples as i64;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_pts += samples as i64`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: `#[warn(clippy::assign_op_pattern)]` on by default
|
|
redundant pattern matching, consider using `is_some()`:
crates/enc-ffmpeg/src/audio/buffered_resampler.rs#L78
warning: redundant pattern matching, consider using `is_some()`
--> crates/enc-ffmpeg/src/audio/buffered_resampler.rs:78:19
|
78 | while let Some(_) = self.resampler.delay() {
| ----------^^^^^^^------------------------- help: try: `while self.resampler.delay().is_some()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
= note: `#[warn(clippy::redundant_pattern_matching)]` on by default
|
|
this `if` statement can be collapsed:
crates/enc-ffmpeg/src/audio/buffered_resampler.rs#L59
warning: this `if` statement can be collapsed
--> crates/enc-ffmpeg/src/audio/buffered_resampler.rs:59:9
|
59 | / if let Some(min_next_pts) = self.min_next_pts {
60 | | if let Some(pts) = frame.pts() {
61 | | frame.set_pts(Some(pts.max(min_next_pts)));
62 | | }
63 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
59 ~ if let Some(min_next_pts) = self.min_next_pts
60 ~ && let Some(pts) = frame.pts() {
61 | frame.set_pts(Some(pts.max(min_next_pts)));
62 ~ }
|
|
|
unneeded `return` statement:
crates/enc-ffmpeg/src/audio/buffered_resampler.rs#L51
warning: unneeded `return` statement
--> crates/enc-ffmpeg/src/audio/buffered_resampler.rs:51:9
|
51 | return remaining_samples;
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
51 - return remaining_samples;
51 + remaining_samples
|
|
|
field `config` is never read:
crates/enc-ffmpeg/src/video/h264.rs#L142
warning: field `config` is never read
--> crates/enc-ffmpeg/src/video/h264.rs:142:5
|
139 | pub struct H264Encoder {
| ----------- field in this struct
...
142 | config: VideoInfo,
| ^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused import: `tracing::trace`:
crates/scap-targets/src/platform/macos.rs#L23
warning: unused import: `tracing::trace`
--> crates/scap-targets/src/platform/macos.rs:23:5
|
23 | use tracing::trace;
| ^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|