Skip to content

New recording flow #2610

New recording flow

New recording flow #2610

Triggered via pull request August 12, 2025 01:35
Status Success
Total duration 10m 50s
Artifacts

ci.yml

on: pull_request
Matrix: Build Desktop
Fit to window
Zoom out
Zoom in

Annotations

6 warnings and 3 notices
this expression creates a reference which is immediately dereferenced by the compiler: apps/desktop/src-tauri/src/windows.rs#L227
warning: this expression creates a reference which is immediately dereferenced by the compiler --> apps/desktop/src-tauri/src/windows.rs:227:72 | 227 | let new_recording_flow = GeneralSettingsStore::get(&app) | ^^^^ help: change this to: `app` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
this let-binding has unit value: apps/desktop/src-tauri/src/target_select_overlay.rs#L181
warning: this let-binding has unit value --> apps/desktop/src-tauri/src/target_select_overlay.rs:181:13 | 181 | let _ = task.abort(); | ^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `task.abort();` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default
this `if` statement can be collapsed: crates/displays/src/main.rs#L123
warning: this `if` statement can be collapsed --> crates/displays/src/main.rs:123:9 | 123 | / if let Some((topmost_window, level)) = relevant_windows.first() { 124 | | if let Some(owner) = topmost_window.owner_name() { 125 | | print!("\rTopmost: {} (level: {}) ", owner, level); 126 | | std::io::Write::flush(&mut std::io::stdout()).unwrap(); 127 | | } 128 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 123 ~ if let Some((topmost_window, level)) = relevant_windows.first() 124 ~ && let Some(owner) = topmost_window.owner_name() { 125 | print!("\rTopmost: {} (level: {}) ", owner, level); 126 | std::io::Write::flush(&mut std::io::stdout()).unwrap(); 127 ~ } |
this `if` statement can be collapsed: crates/displays/src/main.rs#L93
warning: this `if` statement can be collapsed --> crates/displays/src/main.rs:93:5 | 93 | / if let Some(topmost) = cap_displays::Window::get_topmost_at_cursor() { 94 | | if let Some(owner) = topmost.owner_name() { 95 | | println!("Testing icon extraction for: {}", owner); ... | 106 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `#[warn(clippy::collapsible_if)]` on by default help: collapse nested if block | 93 ~ if let Some(topmost) = cap_displays::Window::get_topmost_at_cursor() 94 ~ && let Some(owner) = topmost.owner_name() { 95 | println!("Testing icon extraction for: {}", owner); ... 104 | } 105 ~ } |
accessing first element with `cap_displays::Display::list().get(0)`: crates/displays/src/main.rs#L32
warning: accessing first element with `cap_displays::Display::list().get(0)` --> crates/displays/src/main.rs:32:31 | 32 | let main_display_id = cap_displays::Display::list().get(0).map(|d| d.id()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cap_displays::Display::list().first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default
deref which would be done by auto-deref: crates/displays/src/platform/macos.rs#L271
warning: deref which would be done by auto-deref --> crates/displays/src/platform/macos.rs:271:64 | 271 | .and_then(|v| CGRect::from_dict_representation(&*CFDictionary::from_void(*v))) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&CFDictionary::from_void(*v)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default
Build Desktop (aarch64-apple-darwin, macos-latest)
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520
Clippy
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520
Build Desktop (x86_64-pc-windows-msvc, windows-latest)
The windows-latest label will migrate from Windows Server 2022 to Windows Server 2025 beginning September 2, 2025. For more information see https://github.com/actions/runner-images/issues/12677