Fix svg cursor position #2392
Annotations
10 warnings and 5 notices
|
needlessly taken reference of left operand:
crates/camera/src/macos.rs#L75
warning: needlessly taken reference of left operand
--> crates/camera/src/macos.rs:75:33
|
75 | (None, None) => &d.unique_id().to_string() == info.device_id(),
| --------------------------^^^^^^^^^^^^^^^^^^^^
| |
| help: use the left value directly: `d.unique_id().to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `#[warn(clippy::op_ref)]` on by default
|
|
this `.filter_map(..)` can be written more simply using `.map(..)`:
crates/camera/src/macos.rs#L8
warning: this `.filter_map(..)` can be written more simply using `.map(..)`
--> crates/camera/src/macos.rs:8:5
|
8 | / devices
9 | | .iter()
10 | | .filter_map(|d| {
11 | | Some(CameraInfo {
... |
15 | | })
16 | | })
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
= note: `#[warn(clippy::unnecessary_filter_map)]` on by default
|
|
this `let...else` may be rewritten with the `?` operator:
crates/video-decode/src/ffmpeg.rs#L136
warning: this `let...else` may be rewritten with the `?` operator
--> crates/video-decode/src/ffmpeg.rs:136:13
|
136 | / let Some((stream, packet)) = self.packets.next() else {
137 | | return None;
138 | | };
| |______________^ help: replace it with: `let (stream, packet) = self.packets.next()?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
= note: `#[warn(clippy::question_mark)]` on by default
|
|
struct `ModelIDType` is never constructed:
crates/camera/src/lib.rs#L125
warning: struct `ModelIDType` is never constructed
--> crates/camera/src/lib.rs:125:8
|
125 | struct ModelIDType(String);
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused variable: `s`:
crates/camera-avfoundation/src/lib.rs#L63
warning: unused variable: `s`
--> crates/camera-avfoundation/src/lib.rs:63:13
|
63 | s => return Err(()),
| ^ help: if this is intentional, prefix it with an underscore: `_s`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unused import: `format::Pixel`:
crates/ffmpeg-hw-device/src/lib.rs#L8
warning: unused import: `format::Pixel`
--> crates/ffmpeg-hw-device/src/lib.rs:8:5
|
8 | format::Pixel,
| ^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unsafe function's docs are missing a `# Safety` section:
crates/audio/src/audio_data.rs#L174
warning: unsafe function's docs are missing a `# Safety` section
--> crates/audio/src/audio_data.rs:174:1
|
174 | pub unsafe fn cast_bytes_to_f32_slice(slice: &[u8]) -> &[f32] {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: `#[warn(clippy::missing_safety_doc)]` on by default
|
|
redundant pattern matching, consider using `is_ok()`:
crates/audio/src/audio_data.rs#L111
warning: redundant pattern matching, consider using `is_ok()`
--> crates/audio/src/audio_data.rs:111:23
|
111 | while let Ok(_) = decoder.receive_frame(&mut decoded_frame) {
| ----------^^^^^-------------------------------------------- help: try: `while decoder.receive_frame(&mut decoded_frame).is_ok()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
|
|
redundant pattern matching, consider using `is_ok()`:
crates/audio/src/audio_data.rs#L67
warning: redundant pattern matching, consider using `is_ok()`
--> crates/audio/src/audio_data.rs:67:27
|
67 | while let Ok(_) = decoder.receive_frame(&mut decoded_frame) {
| ----------^^^^^-------------------------------------------- help: try: `while decoder.receive_frame(&mut decoded_frame).is_ok()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
= note: `#[warn(clippy::redundant_pattern_matching)]` on by default
|
|
useless use of `format!`:
crates/audio/src/audio_data.rs#L26
warning: useless use of `format!`
--> crates/audio/src/audio_data.rs:26:32
|
26 | .ok_or_else(|| format!("No Stream"))?;
| ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No Stream".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
|
Clippy
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520
|
|
Clippy
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520
|
|
Build Desktop (aarch64-apple-darwin, macos-latest)
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520
|
|
Build Desktop (aarch64-apple-darwin, macos-latest)
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520
|
|
Build Desktop (x86_64-pc-windows-msvc, windows-latest)
The windows-latest label will migrate from Windows Server 2022 to Windows Server 2025 beginning September 2, 2025. For more information see https://github.com/actions/runner-images/issues/12677
|