Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify installation steps (conda environments) #908

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

raquo
Copy link
Contributor

@raquo raquo commented Oct 29, 2021

This PR is clarifying that the installation instructions are talking about conda environments and not python environments. I'm new to all this so not 100% sure that this is the right thing to say, but it seemed to work for me.

@jmwright
Copy link
Member

@raquo Thanks for doing this. Could you please merge master into your branch? That should fix the failing checks.

This PR is clarifying that the installation instructions are talking about conda environments and not python environments. I'm new to all this so not 100% sure that this is the right thing to say, but it seemed to work for me.
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #908 (9ea6dab) into master (d6c41d7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #908   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          39       39           
  Lines        9130     9130           
  Branches     1017     1017           
=======================================
  Hits         8775     8775           
  Misses        206      206           
  Partials      149      149           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6c41d7...9ea6dab. Read the comment docs.

@raquo
Copy link
Contributor Author

raquo commented Nov 22, 2021

@jmwright So I've just rebased my branch on CadQuery/cadquery master, which is at d6c41d7 as I type this. Now my branch has d6c41d7 as the second-to-last commit, and the last commit is my actual docs change. Still, some checks are failing, not sure why.

@adam-urbanczyk
Copy link
Member

Small doc change - merging. Thanks @raquo !

@adam-urbanczyk adam-urbanczyk merged commit 5f65afd into CadQuery:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants