Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Docker section to readme and fixed two small doc errors #757

Merged
merged 1 commit into from
May 8, 2021

Conversation

jmwright
Copy link
Member

@jmwright jmwright commented May 7, 2021

Will close #747 and #750

I think this will also close #157

@RubenRubens Could you review the Docker section to make sure it captures the information correctly?

@jmwright jmwright requested a review from marcus7070 May 7, 2021 13:28
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #757 (82d3fd5) into master (2b7f39b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files          32       32           
  Lines        7249     7249           
  Branches      789      789           
=======================================
  Hits         6861     6861           
  Misses        255      255           
  Partials      133      133           
Impacted Files Coverage Δ
cadquery/cq.py 91.32% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b7f39b...82d3fd5. Read the comment docs.

@RubenRubens
Copy link
Contributor

Looks good. Thanks @jmwright for the reference on the readme.

Copy link
Member

@marcus7070 marcus7070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @RubenRubens and @jmwright!

@marcus7070 marcus7070 merged commit 85663cb into master May 8, 2021
@marcus7070 marcus7070 deleted the docs-update branch May 8, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workplane polygon documentation - minimum number of sides Provide docker image
3 participants