popPendingEdges and Wires#678
Merged
jmwright merged 3 commits intoCadQuery:masterfrom Mar 10, 2021
Merged
Conversation
Member
Author
|
Just FYI, I tried two ways of solving this.
The first way needed a lot of overloads and casts to satisfy mypy. The experience has made me realise that two methods is the better solution, each method returning a single type. |
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
==========================================
+ Coverage 94.21% 94.27% +0.06%
==========================================
Files 31 31
Lines 6702 6742 +40
Branches 726 727 +1
==========================================
+ Hits 6314 6356 +42
+ Misses 253 252 -1
+ Partials 135 134 -1
Continue to review full report at Codecov.
|
adam-urbanczyk
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will close #621. To summarise:
I'm keeping this a draft PR until I see the test coverage, if it goes down then I'll fix that.