Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force dxf layer name case agreement #630

Merged
merged 3 commits into from
Feb 13, 2021
Merged

force dxf layer name case agreement #630

merged 3 commits into from
Feb 13, 2021

Conversation

greyltc
Copy link
Contributor

@greyltc greyltc commented Feb 11, 2021

fixes #624

@jmwright
Copy link
Member

@greyltc Please have a look at the black lint check error when you get a chance.

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #630 (5ffb1af) into master (b6beba7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
+ Coverage   93.93%   93.94%   +0.01%     
==========================================
  Files          31       31              
  Lines        6526     6543      +17     
  Branches      712      713       +1     
==========================================
+ Hits         6130     6147      +17     
  Misses        258      258              
  Partials      138      138              
Impacted Files Coverage Δ
cadquery/occ_impl/importers.py 88.42% <100.00%> (+0.09%) ⬆️
tests/test_cadquery.py 99.09% <0.00%> (+<0.01%) ⬆️
cadquery/cq.py 89.66% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6beba7...5ffb1af. Read the comment docs.

@jmwright
Copy link
Member

Merging. Thanks @greyltc !

@jmwright jmwright merged commit d1ebfba into CadQuery:master Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dxf layer import exclusion not matching layer names properly
3 participants