Skip to content

Fixed parametricCurve() to use correct stop value#477

Merged
adam-urbanczyk merged 1 commit intoCadQuery:masterfrom
just-georgeb:fixParametricCurve
Oct 13, 2020
Merged

Fixed parametricCurve() to use correct stop value#477
adam-urbanczyk merged 1 commit intoCadQuery:masterfrom
just-georgeb:fixParametricCurve

Conversation

@just-georgeb
Copy link
Copy Markdown
Contributor

parametricCurve() takes a start and stop value as inputs:

:param start: starting value of the parameter t
:param stop: final value of the parameter t

The final value in the current implementation is actually start + stop. This PR fixes it to end at the specified stop value

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 12, 2020

Codecov Report

Merging #477 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #477   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          30       30           
  Lines        5859     5860    +1     
  Branches      624      624           
=======================================
+ Hits         5486     5487    +1     
  Misses        234      234           
  Partials      139      139           
Impacted Files Coverage Δ
cadquery/cq.py 88.29% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd45e0...8167ea4. Read the comment docs.

@adam-urbanczyk
Copy link
Copy Markdown
Member

Thanks @just-georgeb , good catch!

@adam-urbanczyk adam-urbanczyk merged commit c3e9ef5 into CadQuery:master Oct 13, 2020
@just-georgeb just-georgeb deleted the fixParametricCurve branch October 16, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants