Fixed parametricCurve() to use correct stop value#477
Merged
adam-urbanczyk merged 1 commit intoCadQuery:masterfrom Oct 13, 2020
Merged
Fixed parametricCurve() to use correct stop value#477adam-urbanczyk merged 1 commit intoCadQuery:masterfrom
adam-urbanczyk merged 1 commit intoCadQuery:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 30 30
Lines 5859 5860 +1
Branches 624 624
=======================================
+ Hits 5486 5487 +1
Misses 234 234
Partials 139 139
Continue to review full report at Codecov.
|
Member
|
Thanks @just-georgeb , good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parametricCurve() takes a start and stop value as inputs:
The final value in the current implementation is actually
start + stop. This PR fixes it to end at the specified stop value