Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add angular precision #424

Merged
merged 6 commits into from
Aug 8, 2020
Merged

Conversation

winksaville
Copy link
Contributor

This gives flexibility to the programmer when exporting.

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #424 into master will not change coverage.
The diff coverage is 95.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #424   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files          25       25           
  Lines        5306     5306           
  Branches      552      552           
=======================================
  Hits         4966     4966           
  Misses        215      215           
  Partials      125      125           
Impacted Files Coverage Δ
cadquery/occ_impl/exporters/__init__.py 92.63% <90.00%> (ø)
cadquery/occ_impl/shapes.py 90.74% <100.00%> (ø)
tests/test_exporters.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ed1578...5b1cd24. Read the comment docs.

@winksaville
Copy link
Contributor Author

LGTM

@adam-urbanczyk
Copy link
Member

Looks good, thanks @winksaville . @jmwright do you want to merge?

@adam-urbanczyk adam-urbanczyk self-requested a review August 7, 2020 17:20
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @winksaville

@jmwright jmwright merged commit 727f0e1 into CadQuery:master Aug 8, 2020
@winksaville winksaville deleted the add-angularPrecision branch August 8, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants