Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DXF import to master #372

Merged
merged 19 commits into from
Jun 2, 2020
Merged

Add DXF import to master #372

merged 19 commits into from
Jun 2, 2020

Conversation

adam-urbanczyk
Copy link
Member

Follow-up of #351

@adam-urbanczyk
Copy link
Member Author

@jmwright could you merge this once CI becomes green?

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #372 into master will decrease coverage by 0.05%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
- Coverage   95.57%   95.52%   -0.06%     
==========================================
  Files          19       19              
  Lines        4700     4777      +77     
==========================================
+ Hits         4492     4563      +71     
- Misses        208      214       +6     
Impacted Files Coverage Δ
cadquery/occ_impl/importers.py 91.56% <89.83%> (-4.74%) ⬇️
cadquery/cq.py 94.09% <100.00%> (+0.02%) ⬆️
tests/test_importers.py 96.00% <100.00%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8da0571...537c019. Read the comment docs.

@jmwright jmwright merged commit 96a0406 into master Jun 2, 2020
@jmwright
Copy link
Member

jmwright commented Jun 2, 2020

@adam-urbanczyk Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants