feat: Enhance vis.py show routine #1855
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
winksaville
commented
Jun 3, 2025
winksaville
commented
- Add parameters azimuth viewup and clipping_range to allow for improved control of the rendering.
- Always call ResetCamera early so the camera is in a known state before applying user defined parameters, some of which are relative.
- Add parameters azimuth viewup and clipping_range to allow for improved control of the rendering. - Always call ResetCamera early so the camera is in a known state before applying user defined parameters, some of which are relative.
|
I've added this per the suggestion from @adam-urbanczyk in "Enhance show in vis.py" discussion #1844. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1855 +/- ##
=======================================
Coverage 95.66% 95.66%
=======================================
Files 28 28
Lines 7431 7435 +4
Branches 1122 1123 +1
=======================================
+ Hits 7109 7113 +4
Misses 193 193
Partials 129 129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
winksaville
force-pushed
the
enhance-vis-show
branch
from
a11b8d2 to
58e52a1
Compare
|
Anyone have any thoughts on this PR? |
|
Pls give it some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.