Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added documentation for Assembly.save() param mode #1458

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

ZTThomasOberthanner
Copy link
Contributor

mode is only used for STEP files as discussed here
#1457
so I suggest to a line to the comments describing that behaviour

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6869dc6) 94.35% compared to head (fccadf5) 94.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1458   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files          28       28           
  Lines        5809     5809           
  Branches      993      993           
=======================================
  Hits         5481     5481           
  Misses        197      197           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-urbanczyk
Copy link
Member

Thanks @ZTThomasOberthanner !

@adam-urbanczyk adam-urbanczyk merged commit 79e64e5 into CadQuery:master Dec 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants