Fix sketch solver line_point method relative/absolute mixup

[voneiden]

Closes #1127

[codecov]

Codecov Report

Merging #1336 (04d4571) into master (7143ead) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

❗ Current head 04d4571 differs from pull request most recent head 62d2a4c. Consider uploading reports for the commit 62d2a4c to get more accurate results

@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
- Coverage   94.30%   94.16%   -0.15%     
==========================================
  Files          26       26              
  Lines        5584     5584              
  Branches      954      954              
==========================================
- Hits         5266     5258       -8     
- Misses        187      194       +7     
- Partials      131      132       +1     

Impacted Files	Coverage Δ
cadquery/occ_impl/sketch_solver.py	91.19% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[lorenzncode]

The fix itself looks good.

There is an assert missing here in the tests:

cadquery/tests/test_sketch.py

Line 643 in 7143ead

(midpoint - seg1.startPoint()).Length == approx(2)

I'd suggest to add the assert to line 643. It should be sufficient for testing the fix.

    assert (midpoint - seg1.startPoint()).Length == approx(2)

I've added a comment regarding the new pytest with sketch "s8". Since the sketch solver is experimental, it might be easier to keep the tests simple (skip adding the new test) since rework may be required later. @voneiden , @adam-urbanczyk , if you disagree and want to keep the additional test please disregard that item.

[voneiden]

There we go, verified that the assert is indeed enough to test this fix.

[lorenzncode]

Thanks @voneiden!

[voneiden]

Was that an accidental wrong branch for your commit 62d2a4c @adam-urbanczyk ?

[adam-urbanczyk]

It was on purpose - trying to fix appveyor

[adam-urbanczyk]

Green, thanks @voneiden !