Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Shape.geomType __doc__ #1309

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

voneiden
Copy link
Contributor

@voneiden voneiden commented Apr 9, 2023

The description was based on CQ1 implementation. The return type annotation seems to be correct.

The description was probably based on  CQ1 implementation
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #1309 (5f5df51) into master (58a9c72) will not change coverage.
The diff coverage is n/a.

❗ Current head 5f5df51 differs from pull request most recent head cc50149. Consider uploading reports for the commit cc50149 to get more accurate results

@@           Coverage Diff           @@
##           master    #1309   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files          26       26           
  Lines        5495     5495           
  Branches      932      932           
=======================================
  Hits         5179     5179           
  Misses        187      187           
  Partials      129      129           
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 92.80% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adam-urbanczyk adam-urbanczyk merged commit e28d94c into CadQuery:master Apr 11, 2023
@adam-urbanczyk
Copy link
Member

Thanks @voneiden !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants