Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close option to Wire.makePolygon #1257

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

lorenzncode
Copy link
Member

Close wire when creating polygonal face in Sketch

resolves #1180

Close wire when creating polygonal face in Sketch
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #1257 (3f11186) into master (58447f8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 3f11186 differs from pull request most recent head 24ae7bc. Consider uploading reports for the commit 24ae7bc to get more accurate results

@@           Coverage Diff           @@
##           master    #1257   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files          26       26           
  Lines        5432     5434    +2     
  Branches      919      920    +1     
=======================================
+ Hits         5111     5113    +2     
  Misses        190      190           
  Partials      131      131           
Impacted Files Coverage Δ
cadquery/cq.py 92.20% <ø> (ø)
cadquery/occ_impl/shapes.py 92.66% <100.00%> (+0.01%) ⬆️
cadquery/sketch.py 96.34% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@adam-urbanczyk adam-urbanczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @lorenzncode

@jmwright jmwright merged commit 26f05c5 into CadQuery:master Feb 6, 2023
@lorenzncode lorenzncode deleted the 1180-polygon-close branch February 26, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sketch polygon requires a closed list of points
3 participants