Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing fix #1163

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Indexing fix #1163

merged 3 commits into from
Oct 4, 2022

Conversation

adam-urbanczyk
Copy link
Member

Closes #1162

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Merging #1163 (3110deb) into master (9c525bc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1163   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files          26       26           
  Lines        5411     5411           
  Branches      918      918           
=======================================
  Hits         5087     5087           
  Misses        193      193           
  Partials      131      131           
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 92.65% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adam-urbanczyk looks good to me.

The MacOS builds on AppVeyor were acting strangely yesterday, and I had to re-run another PR's job and now this one. Hopefully it completes this time.

@adam-urbanczyk
Copy link
Member Author

All green - merging.

@adam-urbanczyk adam-urbanczyk merged commit d5806e3 into master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in commit 9c525bcfd7bf7f1b8b9aa4370f69cad73806f37a (OCCT7.6)
2 participants