Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin vtk=9.0.1 for ocp 7.5.3 #1075

Merged
merged 2 commits into from
May 2, 2022
Merged

Conversation

lorenzncode
Copy link
Member

Issue #1074

@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (2eeabc8) to head (aaaa448).
Report is 348 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1075   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          40       40           
  Lines        9407     9407           
  Branches     1248     1248           
=======================================
  Hits         9061     9061           
  Misses        204      204           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmwright
Copy link
Member

jmwright commented May 2, 2022

I'm in favor of merging this ASAP. The new VTK version is currently breaking things in CI. @adam-urbanczyk thoughts?

@adam-urbanczyk
Copy link
Member

+1, merging. Thanks @lorenzncode

@adam-urbanczyk adam-urbanczyk merged commit d7724a8 into CadQuery:master May 2, 2022
@lorenzncode lorenzncode deleted the pin-vtk branch May 4, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants