Skip to content

minor changes to Vector class constructor #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 13, 2018

Conversation

justbuchanan
Copy link
Member

  • Allow constructing with a list: Vector([1, 2, 3])
  • change ValueError -> TypeError
  • throw a TypeError if the argument isn't one of the recognized types. This helps catch mistakes earlier rather than later when the vector is used.

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@49e02bb). Click here to learn what that means.
The diff coverage is 91.04%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   92.42%           
=========================================
  Files             ?       17           
  Lines             ?     3552           
  Branches          ?        0           
=========================================
  Hits              ?     3283           
  Misses            ?      269           
  Partials          ?        0
Impacted Files Coverage Δ
cadquery/occ_impl/importers.py 75% <100%> (ø)
tests/TestCadObjects.py 99.05% <100%> (ø)
tests/TestImporters.py 92.3% <100%> (ø)
cadquery/occ_impl/geom.py 77.98% <70%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e02bb...5903e29. Read the comment docs.

@adam-urbanczyk
Copy link
Member

Thanks @justbuchanan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants