Enhance show in vis.py #1844
winksaville
started this conversation in
Ideas
Replies: 1 comment 2 replies
-
Should I just create a from the commit I pointed to above? |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I was using show in vis.py to create a png and discovered that there was no way to designate the ViewUp normal. So I created PR #1837. But I than discovered that the PR was wrong as I wasn't handling None correctly. While revising the PR it seemed to me the implementation of show didn't feel right and also there were other useful parameters not being passed. So I'm creating this discussion thread to talk about what should be done.
First off, by "feel right" I mean that ResetCamera is not called if position or focus are passed. That seems odd as ResetCamera initializes many things and it seems to me the camera parameters should be consistently set regardless of whether you're doing relative or absolute positioning.
As a start I've created another Commit which always invokes ResetCamera and I added parameters:
Also, according to this VTK ResetCamera Orientation example there are also 3 other relative operators which are missing, should they be added as parameters to show?:
Beta Was this translation helpful? Give feedback.
All reactions