Sonar Cube Issue Tracker #3948
Draft
Sonar Cube Issue Tracker #3948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roles/tests-unit/files/FWO.Test/HtmlToPdfTest.cs (lines 21-115) now checks a new FW_SKIP_PDF_TEST environment flag (in addition to the old GitHub-runner heuristic) and uses Assert.Ignore when we intentionally skip the heavy Puppeteer test, so the result is clearly reported as “skipped” instead of silently returning. Added helpers ShouldSkipPdfTest/IsTruthy in the same file to keep the skip logic readable and reusable. roles/tests-unit/tasks/main.yml (lines 25-32) injects FW_SKIP_PDF_TEST=true into the environment for the Ansible-driven dotnet test run, preventing the Puppeteer test from running during test-install (the dedicated GitHub-step that runs HtmlToPdfTest directly is unaffected, because the variable isn’t set there). Tests dotnet test roles/tests-unit/files/FWO.Test/FWO.Test.csproj --filter UrlSanitizerTests dotnet test roles/tests-unit/files/FWO.Test/FWO.Test.csproj --filter HtmlToPdfTest Full dotnet test currently reproduces the same “Test host process crashed” failure you reported; I captured diagnostics in /tmp/dotnet_diag.log if you need to dig further. The targeted suites covering the sanitizer and PDF generation both pass. The crash when running the entire test assembly predates this change and still occurs even with FW_SKIP_PDF_TEST set (identical to the log snippet you sent), but the new env flag allows the Ansible test-install run to bypass the problematic Puppeteer test until that underlying host issue is addressed. Next steps: rerun the test-install workflow with these changes; if the host crash persists even with the skip flag, we’ll need to investigate the other tests/process interactions using the collected diag log.
…b.com/Imat00/firewall-orchestrator into task/importer-rework-reportRulesTests
… IDs for Rulebase and Rule from MockReportRules
…b.com/Imat00/firewall-orchestrator into task/importer-rework-reportRulesTests
Importer Rework - Fix Warnings
…ringExtensions Task-importer-rework unit test string extensions #3801
…-orchestrator-1 into recovered-work
…arnings fix/importer-rework fix sonar warnings
…-no-error-wrong-credentials
PR Enhanced Logging and Fallback for resolving custom fields in compliance check
…-no-error-wrong-credentials
…y-no-error-wrong-credentials fix/importer-rework autodiscovery no error on wrong credentials - forti
do not allow c# builds with warnings
…firewall-orchestrator into merge/rework-dev-to-rework
…-orchestrator into merge/rework-dev-to-rework
…-orchestrator into merge/rework-dev-to-rework
Merge/rework dev to rework
…-orchestrator into merge/rework-dev-to-rework
…firewall-orchestrator into merge/rework-dev-to-rework
Merge/rework dev to rework
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This pull request only exists to highlight existing sonar cube issues and should not be merged