Skip to content

Add RightSideComparisonResult as factResult #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Add RightSideComparisonResult as factResult #396

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d35a58
Add factResult to fact-comparison values
thorin8k Nov 16, 2024
eeafc94
Fix test and comply with styling
thorin8k Nov 16, 2024
33eb4d2
Add valueResult unconditionally and more testing
thorin8k Nov 17, 2024
babfb32
Test for valueResult in factComparison suite
thorin8k Nov 17, 2024
3678a58
Add valueResult to condition serializer
thorin8k Nov 17, 2024
8e8b3f1
Fix serialized tests
thorin8k Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add factResult to fact-comparison values
  • Loading branch information
@thorin8k
thorin8k authored Nov 16, 2024
commit 0d35a5812d4fb3243625d347f08d8b5963a23e53
3 changes: 3 additions & 0 deletions src/rule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,9 @@ class Rule extends EventEmitter {
.then((evaluationResult) => {
const passes = evaluationResult.result
condition.factResult = evaluationResult.leftHandSideValue
if(typeof condition.value === 'object' && condition.value !== null){
condition.value.factResult = evaluationResult.rightHandSideValue;
}
condition.result = passes
return passes
})
Expand Down