Optional argument to QEventLoop constructor for already running loops #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt loop is already running.
|
Nice work, thanks for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain situations, Python is running in an environment where the event loop as already been started. For example when Python is embedded as a scripting language within another application. As such, when creating a QEventLoop, we need to be able to set __is_running to True. I added an optional argument to the constructor that lets us do this.
The value if __is_running is set only after the superclass's constructor is called, because I found a bug in asyncio's BaseEventLoop: an exception occurs during initialization if the event loop reports it is already running. I'll be submitting a patch for that to the asyncio maintainers. In the meantime, setting __is_running at the end of QEventLoop's constructor seems to work fine.
Note: This is identical to a PR I put up for asyncqt here: gmarull/asyncqt#29